Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S2187: Rule should not raise an issue when class is abstract #929

Closed
Evangelink opened this issue Nov 13, 2017 · 1 comment
Closed

Fix S2187: Rule should not raise an issue when class is abstract #929

Evangelink opened this issue Nov 13, 2017 · 1 comment
Assignees
@Evangelink
Labels
Type: False Positive Rule IS triggered when it shouldn't be.
Milestone
6.7

Comments

@Evangelink
Copy link
Contributor

Description

Currently the rule will report an issue on an abstract class but you might want to create some test helper/infrastructure and it is ok if they don't have any test.

Expected behavior

No issue is raised when test class is abstract.

Actual behavior

Issue is raised.

Related information

  • SonarC# Version: 6.6 and less
@Evangelink Evangelink self-assigned this Nov 13, 2017
@Evangelink Evangelink added Area: Rules Type: False Positive Rule IS triggered when it shouldn't be. labels Nov 13, 2017
@Evangelink Evangelink added this to the 6.7 milestone Nov 13, 2017
@Evangelink Evangelink changed the title Update S2187: Rule should not raise an issue when class is abstract Fix S2187: Rule should not raise an issue when class is abstract Nov 13, 2017
@michalb-sonar
Copy link
Contributor

@Evangelink let's add a check if anything inherits from such classes.

@Evangelink Evangelink mentioned this issue Nov 13, 2017
Merged
@sebastien-marichal sebastien-marichal mentioned this issue Jun 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Evangelink Evangelink

Labels
Type: False Positive Rule IS triggered when it shouldn't be.
Projects
None yet
Milestone
6.7
Development

No branches or pull requests
2 participants
@Evangelink @michalb-sonar