Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify S3431: Promote C# rule to SonarWay #4127

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

sebastien-marichal
Copy link
Contributor

Update to LaYC format

Copy link
Contributor

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rules/S3431/exceptions.adoc Outdated Show resolved Hide resolved
rules/S3431/csharp/how-mstest.adoc Outdated Show resolved Hide resolved
@sebastien-marichal
Copy link
Contributor Author

@zsolt-kolbay-sonarsource I am asking you to review again; I made more changes than what you suggested.

Copy link

sonarqube-next bot commented Aug 8, 2024

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

sonarqube-next bot commented Aug 8, 2024

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource merged commit 716a7aa into master Aug 9, 2024
10 of 11 checks passed
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource deleted the sma/modify-s3431 branch August 9, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants