Fix prettier for java files #4986
Merged
+4,002
−4,462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saberduck
reviewed
Dec 3, 2024
package.json
Outdated
| @@ -3,8 +3,8 @@ | |||
| "version": "1.0.0", | |||
| "description": "SonarJS code analyzer", | |||
| "scripts": { | |||
| "format": "prettier --write .", | |||
| "check-format": "prettier --list-different .", | |||
| "format": "prettier --write . --plugin=./node_modules/prettier-plugin-java/dist/index.js", | |||
There was a problem hiding this comment.
perhaps we can create config file as described here https://github.com/jhipster/prettier-java?tab=readme-ov-file#usage instead of using CLI parameters?
|
@zglicz can you pls separate configuration change and the formatting into separate commits? And maybe avoid polluting the branch with rebase/merge commits? Then we can update |
zglicz
commented
Dec 4, 2024
Comment on lines
+150
to
+152
| "plugins": [ | ||
| "prettier-plugin-java" | ||
| ] |
There was a problem hiding this comment.
with this setup, it also works.
|
saberduck
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run formathasn't been formatting java files for quite some time. Let us explicitly invoke theprettier-plugin-javato make it run.