implement recovery for issues

[jmecosta]

finish #758

[guwirth]

@jmecosta checks failing

[jmecosta]

One of the import reports it test is failing g. I will check tonight

[jmecosta]

@guwirth test should be fixed now, however the builds are not running? do you know anything about it

[jmecosta]

took a bit of time, but its building

[guwirth]

Hi @jmecosta, except this

 .*WARN.*The report '.*' seems to be empty, ignoring.
.*ERROR.*The report '.*' seems to be empty.

it looks good to me. Thx for providing this.

Regards,

[guwirth]

@jmecosta other possibility could be to create always only a warning because ValidateRecovery is creating an error ERROR_RECOVERY_KEY == "False".

[guwirth]

@jmecosta not sure if this error message is right? For my understanding:

• in case of CxxPlugin.ERROR_RECOVERY_KEY == "True" this is a warning only?
• in case of CxxPlugin.ERROR_RECOVERY_KEY == "False" this is an error?

[jmecosta]

Yep I will revert that, just seem logic at that time.

On Tue, 1 Nov 2016 20:32 Günter Wirth, [email protected] wrote:

@guwirth requested changes on this pull request.

@jmecosta https://github.com/jmecosta other possibility could be to
create always only a warning because ValidateRecovery is creating an error

ERROR_RECOVERY_KEY == "False".

In
sonar-cxx-plugin/src/main/java/org/sonar/plugins/cxx/utils/CxxReportSensor.java
#985 (review)
:

@@ -84,7 +84,8 @@ public void execute(SensorContext context) {
LOG.debug("{} processed = {}", metric == null ? "Issues" : metric.getName(),
violationsCount - prevViolationsCount);
} catch (EmptyReportException e) {

•      LOG.warn("The report '{}' seems to be empty, ignoring.", report);
  

•      LOG.error("The report '{}' seems to be empty.", report);
  

@jmecosta https://github.com/jmecosta not sure if this error message is
right? For my understanding:

• in case of CxxPlugin.ERROR_RECOVERY_KEY == "True" this is a warning
  only?
• in case of CxxPlugin.ERROR_RECOVERY_KEY == "False" this is an error?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#985 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA_jyLBH2CZu118qWu2qOW2EXpGvJ1lIks5q54W-gaJpZM4Kd0NI
.

[jmecosta]

@guwirth should be ok now