-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade plugin to use the new 5.6 api #913
Conversation
… is not. using this until finding a better alternative
@guwirth this is now ready. please review |
SensorContextTester sensorContext = SensorContextTester.create(new File(".")); | ||
String content = new String(Files.readAllBytes(new File(sensorContext.fileSystem().baseDir(), fileName).toPath()), "UTF-8"); | ||
sensorContext.fileSystem().add(new DefaultInputFile("myProjectKey", fileName).initMetadata(content)); | ||
InputFile cxxFile = sensorContext.fileSystem().inputFile(sensorContext.fileSystem().predicates().hasPath(fileName)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmecosta use CxxFileTesterHelper?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
newIssue.at(location); | ||
newIssue.save(); | ||
} catch (Exception ex) { | ||
LOG.debug("Rule {}", duplicateIncludeRule); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmecosta why not only one LOG.debug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually not log.debug, left behind and used as debug stuff removed
@guwirth this will good base to the rest of the stuff that is needed. keep it open for the weekend and merged afterwards. i found a few issues while trying to get unit test metrics working, that i still need to investage. mostly because of the csharp plugin. i will get back to this after august. last week at work next week, then hollidays |
@jmecosta ready to merge? |
Yep go ahead On Fri, 15 Jul 2016 23:15 Günter Wirth, [email protected] wrote:
|
@guwirth had to tweak the coverage data in the integration tests,we should get thing ok once we implement #909 plus unit test files are no longer reported on the metrics side