Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade plugin to use the new 5.6 api #913

Merged
merged 6 commits into from
Jul 16, 2016

Conversation

jmecosta
Copy link
Member

@jmecosta jmecosta commented Jul 8, 2016

@guwirth had to tweak the coverage data in the integration tests,we should get thing ok once we implement #909 plus unit test files are no longer reported on the metrics side

@jmecosta jmecosta mentioned this pull request Jul 8, 2016
@jmecosta
Copy link
Member Author

jmecosta commented Jul 8, 2016

@guwirth this is now ready. please review

SensorContextTester sensorContext = SensorContextTester.create(new File("."));
String content = new String(Files.readAllBytes(new File(sensorContext.fileSystem().baseDir(), fileName).toPath()), "UTF-8");
sensorContext.fileSystem().add(new DefaultInputFile("myProjectKey", fileName).initMetadata(content));
InputFile cxxFile = sensorContext.fileSystem().inputFile(sensorContext.fileSystem().predicates().hasPath(fileName));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmecosta use CxxFileTesterHelper?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

newIssue.at(location);
newIssue.save();
} catch (Exception ex) {
LOG.debug("Rule {}", duplicateIncludeRule);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmecosta why not only one LOG.debug?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually not log.debug, left behind and used as debug stuff removed

@guwirth
Copy link
Collaborator

guwirth commented Jul 8, 2016

@jmecosta looks good found only minor things. Great job!
👍

@ALL someone else wanna review?

@guwirth guwirth added this to the 0.9.7 milestone Jul 8, 2016
This was referenced Jul 8, 2016
@jmecosta
Copy link
Member Author

jmecosta commented Jul 8, 2016

@guwirth this will good base to the rest of the stuff that is needed. keep it open for the weekend and merged afterwards.

i found a few issues while trying to get unit test metrics working, that i still need to investage. mostly because of the csharp plugin. i will get back to this after august. last week at work next week, then hollidays

@guwirth
Copy link
Collaborator

guwirth commented Jul 15, 2016

@jmecosta ready to merge?

@jmecosta
Copy link
Member Author

Yep go ahead

On Fri, 15 Jul 2016 23:15 Günter Wirth, [email protected] wrote:

@jmecosta https://github.com/jmecosta ready to merge?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#913 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA_jyFJscRrRYuSMG8fXkx_MQ8TSwFF4ks5qV-pKgaJpZM4JHzb3
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants