log only errors for parameter matching #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- MismatchException is used to consume all separators and this is not an error - only create an error message if the closing bracket token is not following an comma token (might not happen)
| @@ -743,19 +743,20 @@ private int matchArguments(List<Token> tokens, List<Token> arguments) { | |||
| break; | |||
| } | |||
| } while (true); | |||
|
|
|||
| } catch (MismatchException me) { | |||
| LOG.debug("Mismatch: expected ','got: '" + rest.get(0).getValue() + "'"); | |||
There was a problem hiding this comment.
Typically this message is:
Mismatch: expected ',' got: ')'
This is the reason for the exception but not an error. Anything different than ',' or ')' is an error. This message could be an error if the ')' case is not reported.
|
ok, but then do we even need to do the debug print. if running with -X it will just print loads of not needed stuff. right? |
|
Yes, the debug information might be huge. I removed this code line. Please check the update. |
|
Code review only without testing with sample 👍 |
|
Try still to run this before merging |
|
looks good: 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error
following an comma token (might not happen)