-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cache coverage data #822
cache coverage data #822
Conversation
Hi @jmecosta no idea. What exactly should this PR do/improve? |
in multiple modules configurations, for example when using the msbuild sonar runner if you have a solution with multiple projects then the parser will parse every report again and again, we have 100 MB reports and solutions with 60-70 projects. so the benifict in this case will be good. ive follow the same approach as here, https://github.com/SonarSource/sonar-dotnet-tests-library/pull/19 |
Gotcha. Is it ready to merge from your side?
|
Nop it does not work :) On Fri, 1 Apr 2016 19:53 Günter Wirth, [email protected] wrote:
|
But anyway leave it open I try to figure out how it's donw when I have a On Fri, 1 Apr 2016 20:25 Jorge Costa, [email protected] wrote:
|
I guess it's a path issue. Different baseDir or slash/backslash ... |
3bcdaf3
to
3ce3529
Compare
@BobSilent notice that you have proposed a similar thing to the .net side. have you tested the solution implemented there? i have tested it and i get some behaviour has this one, the batchextension gets instantiated for each module, rather than only once for all modules. |
75bd9b8
to
e39caa7
Compare
nevermind, its working now. @guwirth ready for review. next to have cache are reports and build log parser |
@jmecosta code looks good but also failing with SQ 5.5-RC1. Start of SQ not possible. |
@jmecosta SQ 5.5-RC1 is another problem. |
@jmecosta merge conflicts. Please rebase and try again. |
e39caa7
to
ad56d73
Compare
@guwirth rebase and squashed. ready to go |
@guwirth whats the issue with 5.5, i try with a local installation and it also fails with this: 2016.04.09 15:44:18 ERROR web[o.a.c.c.C.[.[.[/]] Exception sending context initialized event to listener instance of class org.sonar.server.platform.PlatformServletContextListener |
@jmecosta i proposed a very simple solution there by caching the information for which coverage file the information was already loaded. With caching the information in a static way. If you would have asked me, i would not have reimplemented it here in cxx, as you already have the dotnet library dependency I would have reused the coverage importer from there, by just adding an adapted CxxSensor and CxxParser entrypoint here and using maybe have a dedicated implemention for the bullseye and cobertura parsers here in cxx. |
@BobSilent thanks, i am ensure how much should we depend on the dot test test library since its mostly for manage side. anyway the implementation that ive done its simpler than in the tests library, so it just saves each report coverage(it does not merge). also we need to do some caching on the issues report and buildlog parsing so it was a good exercise to see how to put it together. |
@guwirth do you know a way to get this cache thing working. caches for each module are always empty