reduce logging #821
reduce logging #821
Conversation
| @@ -575,8 +575,6 @@ PreprocessorAction handleIncludeLine(AstNode ast, Token token, String filename) | |||
| } finally { | |||
| currentFileState = globalStateStack.pop(); | |||
| } | |||
| } else { | |||
| LOG.debug("[{}:{}]: skipping already included file '{}'", new Object[]{filename, token.getLine(), includedFile}); | |||
There was a problem hiding this comment.
this is not relevant at all, if already included then good. no need to ack.
jmecosta
force-pushed
the
reduce-duplicated-logging
branch
2 times, most recently
from
a0d1f67
to
ebe6b6c
Compare
|
@guwirth can you check this please, want to know what is you feeling about this logging issue |
|
Hello @jmecosta, In general I think it's a good idea to clean-up the logging. All changes which provide more meaningful information or remove redundant items are fine. This should focus mainly on non debug mode. In debug mode I would be more careful. Here I would keep most of the information independent how big the resulting LOG file is. It's the only way to give maintenance to other users. I will add more detailed comments above. Regards, |
| LOG.warn("Undefined functionlike macro '{}' assuming 0", macroName); | ||
| String value = ""; | ||
|
|
||
| value = preprocessor.expandFunctionLikeMacro(macroName, restTokens); |
There was a problem hiding this comment.
Should be in one line?
String value = preprocessor.expandFunctionLikeMacro(macroName, restTokens);
|
@jmecosta review done |
|
@guwirth thanks, i will update those and comment on the others |
…more meaningful information for the analysis
jmecosta
force-pushed
the
reduce-duplicated-logging
branch
from
f83feea
to
3e4f4c9
Compare
|
@guwirth updated according with your cr comments. the only missing point is https://github.com/SonarOpenCommunity/sonar-cxx/pull/821/files#diff-1b5817791fecc29b992d6f86144b29d7L147 imo we will have time to detect regressions becuase of this once we start using it. |
|
@jmecosta looks good but build with SQ 5.5-RC1 in Travis is failing? |
|
@jmecosta SQ 5.5-RC1 is another problem. |
. silence parse stacktrace and instead print more meaningful information for the analysis
. clean some duplicated logging
@guwirth the current logging is printing stacktraces that are not meaninfull or not working. ex:
[14:39:57] : [Step 3/3] 14:39:57.857 ERROR - {}
[14:39:57] : [Step 3/3] org.sonar.cxx.preprocessor.CxxPreprocessor$MismatchException: null
[14:39:57] : [Step 3/3] at org.sonar.cxx.preprocessor.CxxPreprocessor.matchArgument(CxxPreprocessor.java:795) [cxx-squid-0.9.6-SNAPSHOT.jar:na]
[14:39:57] : [Step 3/3] at org.sonar.cxx.preprocessor.CxxPreprocessor.matchArguments(CxxPreprocessor.java:739) [cxx-squid-0.9.6-SNAPSHOT.jar:na]
For some reason when doing this:
throw new EvaluationException("Unknown expression type '" + nodeType + "'");
those dont show up in stacktrace. instead a 200 lines stack trace is printed, with this change a debug log of 160 MB went to 26 MB