Fix #766: Handle relative report paths with backticks outside basedir. #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ks outside basedir. It was possible to have an NPE when normalizing backticks on relative paths if the backticks moved the directory too far back. This change will handle invalid normalization of relative paths. Normalization is reattempted against the absolute path, and if it is still invalid then it is not given to the directory scanner, which does not accept null elements.
| String normalizedPath = FilenameUtils.normalize(reportPath); | ||
| if (normalizedPath != null && new File(normalizedPath).isAbsolute()) { | ||
| includes.add(normalizedPath); | ||
| continue; |
There was a problem hiding this comment.
@mjdetullio I'm not a fan of continue in loops. Think if / else if / else would be the same ....
guwirth
added a commit
that referenced
this pull request
Feb 20, 2016
Fix #766: Handle relative report paths with backticks outside basedir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible to have an NPE when normalizing backticks on relative
paths if the backticks moved the directory too far back. This change
will handle invalid normalization of relative paths.
Normalization is reattempted against the absolute path, and if it is
still invalid then it is not given to the directory scanner, which does
not accept null elements.