Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rule CycleBetweenPackages Sqale remediation parameters #735

Merged
merged 2 commits into from
Jan 4, 2016

Conversation

Bertk
Copy link
Contributor

@Bertk Bertk commented Jan 3, 2016

see #734

@guwirth
Copy link
Collaborator

guwirth commented Jan 3, 2016

Wait for

The cxx-checks sqale definitions should be removed from sonar-cxx-plugin/src/main/resources/com/sonar/sqale/cxx-model.xml.

before I merge this?

@Bertk
Copy link
Contributor Author

Bertk commented Jan 3, 2016

The cxx-model.xml file does not contain any cxx-checks definitions. This was removed before with guwirth@b49577b.
I also deleted the obsolete cxx-model-project files because they are not in sync with cxx-model.xml.

@jmecosta
Copy link
Member

jmecosta commented Jan 3, 2016

Ok that's good, so all should be oknow ?

On Sun, Jan 3, 2016, 17:52 Bert [email protected] wrote:

The cxx-model.xml file does not contain any cxx-checks definitions. This
was removed before with guwirth/sonar-cxx@b49577b
guwirth@b49577b
.
I also deleted the obsolete cxx-model-project files because they are not
in sync with cxx-model.xml.


Reply to this email directly or view it on GitHub
#735 (comment)
.

@Bertk
Copy link
Contributor Author

Bertk commented Jan 3, 2016

I am not sure. There are other checks which use @SqaleConstantRemediation as well and this is a potential background tasks exception (SQ 5.2 or 5.3). I have not all checks activated but some of them and they did not create an exception.
So for now - I assume the issue is fixed and only 'cxx:CycleBetweenPackages' created an exception. Unfortunately I do not know why this is limited to 'cxx:CycleBetweenPackages'
@guwirth: When will you create the next RC? We should now ready to target SQ5.3 aren't we?

@guwirth
Copy link
Collaborator

guwirth commented Jan 3, 2016

@Bertk over AppVeyor there is always the latest plugin available. I did no tests with 5.3 up to now and integration tests are also red. The issue list is also still very long :-(

@guwirth
Copy link
Collaborator

guwirth commented Jan 3, 2016

PR 👍

@guwirth guwirth added the bug label Jan 3, 2016
@guwirth guwirth added this to the M 0.9.5 milestone Jan 3, 2016
guwirth added a commit that referenced this pull request Jan 4, 2016
fix rule CycleBetweenPackages Sqale remediation parameters
@guwirth guwirth merged commit b492b35 into SonarOpenCommunity:master Jan 4, 2016
@Bertk Bertk deleted the fixes branch February 21, 2016 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants