Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add build for windows #651

Merged
merged 4 commits into from
Oct 21, 2015

Conversation

jmecosta
Copy link
Member

this add build for windows... current sources are not building on windows...

we need to setup a build in appveyour:

@guwirth can you check if after you create a account in appveyour are you able to setup builds for wenns/cxxplugin?

no additicional configuration is needed after this yml is created. see my account: https://ci.appveyor.com/project/jorgecosta/sonar-cxx

@guwirth
Copy link
Collaborator

guwirth commented Oct 19, 2015

.... are you able to setup builds for wenns?

No I'm sorry.

@jmecosta
Copy link
Member Author

@wenns can you do it?

case drive letters

change drive

normalize paths also in tests

normalize paths also in tests
@jmecosta
Copy link
Member Author

@guwirth rebase and tests are now passing on windows:
https://ci.appveyor.com/project/jorgecosta/sonar-cxx

artifacts created: https://ci.appveyor.com/project/jorgecosta/sonar-cxx/build/artifacts

we should also use badges in the readme to show the build is green:
https://ci.appveyor.com/api/projects/status/mi5ft6fo1qx3q8o7?svg=true

@guwirth guwirth added this to the M 0.9.4 milestone Oct 21, 2015
guwirth added a commit that referenced this pull request Oct 21, 2015
@guwirth guwirth merged commit 94adcd5 into SonarOpenCommunity:master Oct 21, 2015
@guwirth
Copy link
Collaborator

guwirth commented Oct 21, 2015

Hi @jmecosta really cool. We should link the final artifacts somehow. As far as I understand the plugin binary is created with every merge => #293 ?

@jmecosta
Copy link
Member Author

Appveyour supports deployment of artifact to github, it can even do release for you if you want base on tag.

Question here is how to enable the build if you can't access weens repository

@jmecosta
Copy link
Member Author

@guwirth, @wenns what about if moving the repository inot one organization, permissions are better handle like that and its possible to any user to configure builds for a certain repository

@guwirth
Copy link
Collaborator

guwirth commented Oct 25, 2015

inot one organization

What do you mean with this?

Heard also nothing from @wenns for a longer time. So I'm also interested in his opinion how to continue...

@jmecosta
Copy link
Member Author

@guwirth https://github.com/SonarCommunity is a organization. i am for example in these
image

and i can setup builds for any of the projects in those organizations. we could call it SonarOpenCommunity

@guwirth guwirth mentioned this pull request Oct 25, 2015
@wenns
Copy link
Contributor

wenns commented Oct 27, 2015

Hi @guwirth, @jmecosta,

Im not opposed to moving the repository into such an organisation. My situation is changed and I cannot participate in further development much, anyway. And I'm grateful to you guys for maintaining this code base.

As for the actual transfer: just say what I should do and I will transfer the repo.

@jmecosta
Copy link
Member Author

good to hear from you @wenns . @guwirth if you are ok with it, i can create the organization and give admin permissions to you and wenns?

any suggestiongs for the name? i gave SonarOpenCommunity, or SonarCxxCommunity

@guwirth
Copy link
Collaborator

guwirth commented Oct 27, 2015

@jmecosta it is ok for me to move it to an organization. With the name I'm not sure because Sonar, SonarQube and SonarSource are protected trademarks. Also it depends a little bit if only cox plugin should be in the organization or more?

@jmecosta
Copy link
Member Author

using sonar as part of a bigger word its perfectly ok, sonar is not trademark of sonarsource, thats the reason they add to change it to SonarQube, however Sonar is still used in SonarQube and there is no problems with it....

SonarOpenCommunity, or SonarCxxCommunity are perfectly fine. Both, i think they can have more than just the cxx plugin for sure, if choosing the first we are stating that anything not related with cxx plugin can be made available if choosing the later we are stating only cxx ecosystem tools will be available.

Really depends were we want to go with this, i for first have a couple of plugins that i would not mind having them there. like sonar.msbuild.plugin, sonar.fsharp.pluig, sonar.xaml.plugin. also nuget tasks to support cxx plugin etc.

this all organization business is very flexible, you can move those repos when you want and to where you want

@guwirth
Copy link
Collaborator

guwirth commented Oct 28, 2015

I tend to SonarOpenCommunity.

@jmecosta
Copy link
Member Author

Lets try it then

@jmecosta
Copy link
Member Author

@guwirth done, can you transfer the repo. If not @wenns can you do it. (afte that you can clone so that the repository still exist at your side)

@guwirth
Copy link
Collaborator

guwirth commented Oct 28, 2015

@jmecosta don't have access. @wenns has to do it.

@wenns
Copy link
Contributor

wenns commented Oct 31, 2015

Its done

@jmecosta
Copy link
Member Author

Thanks @wenns

@guwirth
Copy link
Collaborator

guwirth commented Oct 31, 2015

@wenns thanks a lot for your cpntribution the last years. It's really a pity that you have no more time for doing this...

@Bertk
Copy link
Contributor

Bertk commented Nov 1, 2015

@wenns thanks a lot for your advices and for your work on SonarQube C++ community plug-in.

@jmecosta
Copy link
Member Author

jmecosta commented Nov 1, 2015

@wenns thank you a lot also for starting this project, and hopefully you can still contribute some time in future. we try to maintain it as possible

@wenns
Copy link
Contributor

wenns commented Nov 1, 2015

Thanks for taking over. It would be a real pity to see this code decay. Keep up good work, guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants