remove deprecated fromIOFile

[guwirth]

• close Remove deprecated fromIOFile  #629
• replace File.fromIOFile with FileSystem.inputFile
• replace org.sonar.api.resources.File with org.sonar.api.batch.fs.InputFile
• use org.sonar.api.batch.fs.internal.DefaultFileSystem in unit tests
• add addInputFile to TestUtils: all files listed in report files must be added to DefaultFileSystem
  • for reports with absolute paths there are two versions needed: one for Window and one for Linux
• close limit report line number #611, close PC-lint report may create SonarException in decorator #600, close Execute decorators failing #625: add fix for https://jira.sonarsource.com/browse/SONAR-6792

[guwirth]

@jmecosta & @Bertk: PR is ready to review and test. Are there any changes in performance on your environment?

[jmecosta]

I will try during this week and report back

[guwirth]

Did a comparison between SQ 3.7.4 / CXX plugin 0.9.1 and SQ 5.1.1 / CXX plugin 0.9.4 & this PR:
SQ 5.1.1 & this PR is between 30% and 200% faster.

[jmecosta]

got 1 failed tests in the bullseye coverage test in windows, will comment and proceed with test in server

//@test
public void shoulParseTopLevelFiles() {

[guwirth]

@jmecosta Strange. Developing and testing only on Windows and it is working fine on my system?

[jmecosta]

java 8?

[jmecosta]

ok, so its because of this:

22:15:11.133 [main] INFO CxxPlugin - Added report 'D:\Development\SonarQube\cxx\sonar-cxx\sonar-cxx-plugin\target\test-classes\org\sonar\plugins\cxx\reports-project\coverage-reports\bullseye\bullseye-coverage-drive-letter-without-slash-win.xml' (parsed by: BullseyeParser) to the coverage data
22:15:13.879 [main] DEBUG CxxPlugin - Saving coverage measures for file 'E:\anotherincludeattop.h'
22:15:13.892 [main] DEBUG CxxPlugin - Saving coverage measures for file 'E:\test2\test2.c'
22:15:13.893 [main] DEBUG CxxPlugin - Saving coverage measures for file 'E:\main.c'
22:15:13.895 [main] WARN CxxPlugin - Cannot find the file 'E:\Test\test.c', ignoring coverage measures

Test is capital, not totally sure why does it work there... using windows 10 btw

[guwirth]

Have to test this tomorrow again. But I think was only working on my system with capital drive letter? But no more sure... also don't know why drive letter is on some system upper case and on some lower case? Strange is also that DefaultFileSystem is not able to handle this?

Am 14.09.2015 um 21:16 schrieb Jorge Costa [email protected]:

ok, so its because of this:

22:15:11.133 [main] INFO CxxPlugin - Added report 'D:\Development\SonarQube\cxx\sonar-cxx\sonar-cxx-plugin\target\test-classes\org\sonar\plugins\cxx\reports-project\coverage-reports\bullseye\bullseye-coverage-drive-letter-without-slash-win.xml' (parsed by: BullseyeParser) to the coverage data
22:15:13.879 [main] DEBUG CxxPlugin - Saving coverage measures for file 'E:\anotherincludeattop.h'
22:15:13.892 [main] DEBUG CxxPlugin - Saving coverage measures for file 'E:\test2\test2.c'
22:15:13.893 [main] DEBUG CxxPlugin - Saving coverage measures for file 'E:\main.c'
22:15:13.895 [main] WARN CxxPlugin - Cannot find the file 'E:\Test\test.c', ignoring coverage measures

Test is capital

—
Reply to this email directly or view it on GitHub.

[jmecosta]

nothing big for me found, time are almost the same as with previous versions

[guwirth]

@jmecosta Thanks for testing.

Will try to find a solution for the drive letter miracle an merge it then.