Treat relative paths in Cobertura reports as relative to the project … #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…base directory as opposed to the current directory.
| @@ -37,6 +37,14 @@ | |||
| * {@inheritDoc} | |||
| */ | |||
| public class CoberturaParser implements CoverageParser { | |||
There was a problem hiding this comment.
@abbeyj looks like a specific solution for CoberturaParser. Could you move this baseDir to CoverageParser to make it more generic please.
There was a problem hiding this comment.
CoverageParser is an interface so I can't move it there. Do you want me to create a base class and put baseDir there? If so, do you have a preference for a name?
|
@abbeyj Sorry for the late answer. Would do it like here https://github.com/wenns/sonar-cxx/blob/master/sonar-cxx-plugin/src/main/java/org/sonar/plugins/cxx/utils/CxxReportSensor.java New class CxxCoverageParser which implements CoverageParser. Current location of your class in coverage folder is ok. |
…erageParserBase".
|
Thx |
guwirth
added a commit
that referenced
this pull request
Aug 30, 2015
Treat relative paths in Cobertura reports as relative to the project …
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…base directory as opposed to the current directory.
This is intended to address #426. That issue is currently marked closed but it is not fixed I've requested that it be reopened.