Added constexpr check to magic number checker. #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could somebody provide some detail why the build fails? The log just says "Couldn't start SonarQube", which is not very helpful. I would fix the issue, but without any information this will be hard. |
| @@ -43,13 +45,19 @@ int someData[] = { | |||
|
|
|||
| static const int i1 = 10; // Compliant | |||
| int i2 = 11; // Non-Compliant | |||
| constexpr int compliant1 = 10; | |||
There was a problem hiding this comment.
Maybe you can add //compliant -or- // non-compliant also to your new lines?
|
Think this was an Travis CI problem. We had this also in the past. |
|
Hi, I've added the Compliant comments to the cpp test file. The travis also passes now. |
guwirth
added a commit
that referenced
this pull request
Aug 28, 2015
Added constexpr check to magic number checker.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added constexpr check to MagicNumberCheck to not report violations on constexpr definitions.