Improve VC++ build log parser #537
Conversation
|
OK and now I really wany to see the main changes on this. Interested on seeing how you manage to get all info using only normal info |
| @@ -177,7 +177,7 @@ public void shouldHandleSpeciificV120OptionsCorrectly() { | |||
|
|
|||
| assertThat(config.getIncludeDirectories().size()).isEqualTo(0); | |||
| List<String> defines = config.getDefines(); | |||
| assertThat(defines.size()).isEqualTo(commonDefines + 8); | |||
There was a problem hiding this comment.
I moved some defines to ParseCommonCompilerOptions() and the compiler version specific part is defined individually e.g.:
AddMacro("__cplusplus=199711L", fileElement);
if ... AddMacro("__cplusplus_winrt=201009", fileElement);
AddMacro("_MSC_VER=1900", fileElement);
AddMacro("_MSC_FULL_VER=190022816", fileElement);
AddMacro("_MFC_VER=0x0C00", fileElement);
The parameter parsing must not be separated as long there is no conflict.
The define for "_M_ARM_FP" is removed (see other comment).
|
@jmecosta Did you have some time to do some tests? I think we are now ready for the merge. |
|
@Bertk i was waiting for the review comments, i will do the tests today. |
|
seems to be running just fine. CR ok |
|
@Bertk could you rebase and squash please |
|
Sorry. I merged the updates from the master but this should also work for the CI. |
|
@Bertk could you squash (merge commits) please. Much easier to handle in case of problems. |
Bertk
force-pushed
the
EnhanceVC-BuildLogParser
branch
from
4f80823
to
9f7fdc6
Compare
Tweak VC++ build log parser for visual studio builds logs using normal verbosity set values for pre-defined macros Avoid parser errors like "Error evaluating expression '' for AstExp 'IDENTIFIER: _NATIVE_WCHAR_T_DEFINED', assuming 0" incorporate review comments Rearrange VS2010 parameter - remove constant commonDefines - move VS2010 specific command parameter to ParseV100CompilerOptions()
Bertk
force-pushed
the
EnhanceVC-BuildLogParser
branch
from
9f7fdc6
to
555d075
Compare
|
I spend some time to make this work "git rebase -i HEAD~4". Notepad++ had a nasty effect which saved the information without any user interaction and I use now notepad to get a chance to modify the instructions - just wasted some time 😑 |
|
With TortoiseGit it's easy going. |
|
But thx will merge it. |
Tweak VC++ build log parser for visual studio builds logs using normal
verbosity