Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo how to set default values for sqale #469

Closed
wants to merge 1 commit into from
Closed

demo how to set default values for sqale #469

wants to merge 1 commit into from

Conversation

guwirth
Copy link
Collaborator

@guwirth guwirth commented Apr 17, 2015

@todo: set the "right" Characteristic

@jmecosta: maybe you have more experience with this? Is it possible to define an own 'characteristic'?
I tested this and currently it is under 'Security > Errors'

@todo: set the "right" Characteristic
//FIXME: set internal key to key to ensure rule templates works properly : should be removed when SONAR-6162 is fixed.
.setInternalKey(rule.key())
// set default Technical Debt values for 'other' rules
.setDebtSubCharacteristic("ERRORS")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should not do this, setting these defaults values are going to cause more issues than not. Because most issues from other rules are not belonging any "default". Same goes for time to fix. adding default values like you are over or uderestimating everything that goes into sonar

I tought you would more including a parser for users to define their own values, imo that would be more usefull.

@guwirth
Copy link
Collaborator Author

guwirth commented Apr 17, 2015

I tought you would more including a parser for users to define their own values, imo that would be more usefull.

Yes that is the thing I like additional to do.

Question with this demo was if something like this makes sense? In our case most of the issues come from 'other' which results in 'no' Technical Debt currently.

@jmecosta
Copy link
Member

I dont think it makes sense since even the categorization should be totally
off, there will be rules belonging to test category that will show under
what you define as default so people will need to change those anyway.

On Fri, Apr 17, 2015, 19:16 Günter Wirth [email protected] wrote:

I tought you would more including a parser for users to define their own
values, imo that would be more usefull.

Yes that is the thing I like additional to do.

Question with this demo was if something like this makes sense? In our
case most of the issues come from 'other' which results in 'no' Technical
Debt currently.


Reply to this email directly or view it on GitHub
#469 (comment).

@guwirth
Copy link
Collaborator Author

guwirth commented Jun 7, 2015

see #529 instead

@guwirth guwirth closed this Jun 7, 2015
@guwirth guwirth deleted the enhancement/467_sqale_for_other_rules branch September 16, 2015 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants