Enhancement/multi module with reactor #358

jmecosta · 2015-01-04T13:52:30Z

kind of rebase... clean reactor

wenns · 2015-01-06T11:52:17Z

Now I have played a little bit this this stuff I know better whats going on.

This multi-module thing is a mine field. This PR hacks the plugin to make the modules pull reports which actually meant to be project-level. This has all sorts of effects, e.g.:

the xunit simple mode is not working
reports are processed N times (1 would be sufficient)
reports are producing lots of wanings of type
'could not find file ' because this file is in an other module
project-level violations will be assigned to each module
etc.

I have mixed feeling with this. Can we do better? Comments?
Meanwhile I'll test the scenario where reports are per module and see how it works.

jmecosta · 2015-01-06T12:50:20Z

the problems you pointed out have been already also pointed out for c# plugin. and in fact they have a ticket http://jira.codehaus.org/browse/SONARVS-59 to make it optional. this would mean that we actually do not need any of this (?). also having mix feelings

am not sure what people that use multimodule not in this way say about. any way...

imo the issues you mention are not a implementation issue of the cxx plugin, rather a way the platform deals with this. any way, you should probably state that when using multi modules all these limitations apply. at least until we figure out

jmecosta · 2015-01-06T15:08:11Z

not sure if this is a good idea, but it prevents issues with duplicated metrics

…h-reactor

…cate data" This reverts commit c5125d6.

jmecosta · 2015-01-06T16:11:02Z

yeah this is a mess :) but the alternative for us is to run the analysis per module and save xmls per module. this is a much harder setup.

ive made so now that the xunit sensor in simple mode should run only at root of the project.. added the correspondent bdd.

wenns · 2015-01-06T18:11:44Z

Mess it is... Raw and hacky. And Im not even half through the most important scenarios for multi-module. Also, there is no clear policy or spec from the platform or other plugins, at least none Im aware of. This feature seems to come from the witsh to support maven modules, without much design work.
Anyway. I want to experement further and Im willing to finish it. We'll see.

jmecosta · 2015-01-06T19:05:57Z

not sure whats going on, on window the tests are passing just fine. in unix they are not... apparenty the search function is not able to find the resources

jmecosta · 2015-01-06T20:31:13Z

should now be green... it was a issue with the path separator in the reports

wenns · 2015-01-10T18:41:45Z

Sorry, will skip this in 0.9.2

guwirth · 2015-04-12T08:11:14Z

This was a lot of work and is an useful feature.
@Bertk If you could do final testing I would merge it after rebase.

Bertk · 2015-04-12T08:14:14Z

I can test it next Sunday only.

…-module-with-reactor Conflicts: sonar-cxx-plugin/src/main/java/org/sonar/plugins/cxx/compiler/CxxCompilerSensor.java sonar-cxx-plugin/src/main/java/org/sonar/plugins/cxx/coverage/CxxCoverageSensor.java sonar-cxx-plugin/src/main/java/org/sonar/plugins/cxx/cppcheck/CxxCppCheckSensor.java sonar-cxx-plugin/src/main/java/org/sonar/plugins/cxx/externalrules/CxxExternalRulesSensor.java sonar-cxx-plugin/src/main/java/org/sonar/plugins/cxx/pclint/CxxPCLintSensor.java sonar-cxx-plugin/src/main/java/org/sonar/plugins/cxx/rats/CxxRatsSensor.java sonar-cxx-plugin/src/main/java/org/sonar/plugins/cxx/utils/CxxReportSensor.java sonar-cxx-plugin/src/main/java/org/sonar/plugins/cxx/valgrind/CxxValgrindSensor.java sonar-cxx-plugin/src/main/java/org/sonar/plugins/cxx/veraxx/CxxVeraxxSensor.java sonar-cxx-plugin/src/main/java/org/sonar/plugins/cxx/xunit/CxxXunitSensor.java sonar-cxx-plugin/src/test/java/org/sonar/plugins/cxx/TestUtils.java sonar-cxx-plugin/src/test/java/org/sonar/plugins/cxx/compiler/CxxCompilerSensorTest.java sonar-cxx-plugin/src/test/java/org/sonar/plugins/cxx/coverage/CxxCoverageSensorTest.java sonar-cxx-plugin/src/test/java/org/sonar/plugins/cxx/cppcheck/CxxCppCheckSensorTest.java sonar-cxx-plugin/src/test/java/org/sonar/plugins/cxx/pclint/CxxPCLintSensorTest.java sonar-cxx-plugin/src/test/java/org/sonar/plugins/cxx/rats/CxxRatsSensorTest.java sonar-cxx-plugin/src/test/java/org/sonar/plugins/cxx/utils/CxxReportSensorTest.java sonar-cxx-plugin/src/test/java/org/sonar/plugins/cxx/utils/CxxReportSensor_getReports_Test.java sonar-cxx-plugin/src/test/java/org/sonar/plugins/cxx/valgrind/CxxValgrindSensorTest.java sonar-cxx-plugin/src/test/java/org/sonar/plugins/cxx/xunit/CxxXunitSensorTest.java

jmecosta · 2015-04-12T19:48:08Z

@Bertk i had to disable one of your tests. the vc log contains absolute paths that do not correspond to the place where i run the tests. so they fail. can you take a look to see if test data needs to be modified?

…-module-with-reactor Conflicts: sonar-cxx-plugin/src/test/java/org/sonar/plugins/cxx/compiler/CxxCompilerSensorTest.java

jmecosta · 2015-04-17T19:41:22Z

@guwirth something wrong with Travis some builds are failing while running behave

guwirth · 2015-04-17T19:50:36Z

@jmecosta I had this also twice this week. After triggering again a build with the same sources it worked. I'm not that familiar with Travis. I'm not sure if this is a Travis issue or a problem with our build script.

guwirth · 2015-04-18T05:57:13Z

integration-tests/testdata/cpp-multimodule-project/sonar-project.properties

+sonar.host.url=http://localhost:9000
+
+sonar.modules=cli,lib,package1,package2
+cli.sonar.projectBaseDir=cli


Are all these settings (cli, doxygen, ...) needed or can they removed?

Only doxygen is redundant but its not worth it

On Sat, Apr 18, 2015, 08:57 Günter Wirth [email protected] wrote:

In
integration-tests/testdata/cpp-multimodule-project/sonar-project.properties
#358 (comment):

@@ -0,0 +1,56 @@
+sonar.host.url=http://localhost:9000
+
+sonar.modules=cli,lib,package1,package2
+cli.sonar.projectBaseDir=cli

Are all these settings (cli, doxygen, ...) needed or can they removed?

—
Reply to this email directly or view it on GitHub
https://github.com/wenns/sonar-cxx/pull/358/files#r28641725.

…verywhere

jmecosta · 2015-04-18T06:08:39Z

@guwirth @Bertk if all goes well in travis this pull request should be ok. ive enabled the test that ive earlier disable and change the paths in the report to be relative.

Paths there were of type : c:\tfs_server\bla ive patched those one to be relative. (usually this is not a issue because c:\tfs_server is the root of the project) i think this shoud be fine to test the sensor

guwirth · 2015-04-18T06:12:50Z

There were some complaints from @wenns in January, are they solved/answered?

the xunit simple mode is not working
reports are processed N times (1 would be sufficient)
reports are producing lots of wanings of type
'could not find file ' because this file is in an other module
project-level violations will be assigned to each module
etc.

jmecosta · 2015-04-18T07:58:23Z

I think some, but I guess improvements can be done later. This initial
support is good enough for multi module users. But is up to you guys.

On Sat, Apr 18, 2015, 09:12 Günter Wirth [email protected] wrote:

There were some complaints from @wenns https://github.com/wenns in
January, are they solved/answered?

the xunit simple mode is not working

reports are processed N times (1 would be sufficient)

reports are producing lots of wanings of type 'could not find file '
because this file is in an other module

project-level violations will be assigned to each module etc.

—

Reply to this email directly or view it on GitHub
#358 (comment).

guwirth · 2015-04-18T08:27:15Z

@jmecosta could rebase and squash (combine multiple commits into one) your PR please. I will merge it then for testing.

…eactor Enhancement/multi module with reactor

jmecosta · 2015-04-18T08:59:36Z

You ended up merging, was doing the rebase a bit later. But not now :)

On Sat, Apr 18, 2015, 11:56 Günter Wirth [email protected] wrote:

Merged #358 #358.

—
Reply to this email directly or view it on GitHub
#358 (comment).

guwirth · 2015-04-18T09:03:11Z

Sorry don't catch you. Should I redo the merge? Thought is finished for testing?

Am 18.04.2015 um 10:59 schrieb Jorge Costa [email protected]:

You ended up merging, was doing the rebase a bit later. But not now :)

On Sat, Apr 18, 2015, 11:56 Günter Wirth [email protected] wrote:

Merged #358 #358.

—
Reply to this email directly or view it on GitHub
#358 (comment).

—
Reply to this email directly or view it on GitHub.

jmecosta · 2015-04-18T09:05:25Z

No its fine, you ask to rebase and squash. But you ended up merging as is

On Sat, Apr 18, 2015, 12:03 Günter Wirth [email protected] wrote:

Sorry don't catch you. Should I redo the merge? Thought is finished for
testing?

Am 18.04.2015 um 10:59 schrieb Jorge Costa [email protected]:

You ended up merging, was doing the rebase a bit later. But not now :)

On Sat, Apr 18, 2015, 11:56 Günter Wirth [email protected]
wrote:

Merged #358 #358.

—
Reply to this email directly or view it on GitHub
#358 (comment).

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#358 (comment).

jmecosta and others added 4 commits January 4, 2015 15:05

introduce project reactor to look for reports

e714d3e

fix compilation

32eca48

add test data for multi module

8b58164

multi module test.. failing in current code

318efc6

jmecosta mentioned this pull request Jan 4, 2015

introduce project base dir property to search for report path #252

Closed

guwirth added this to the M 0.9.2 milestone Jan 5, 2015

guwirth assigned jmecosta Jan 5, 2015

jmecosta mentioned this pull request Jan 5, 2015

Allow absolute report path to fix issue #278, which can help for issue #252 #344

Closed

in multi module, run only at root level so that we dont duplicate data

c5125d6

Jorge Costa added 4 commits January 6, 2015 17:45

Merge branch 'bdd/multimodule-test' into enhancement/multi-module-wit…

858c328

…h-reactor

Revert "in multi module, run only at root level so that we dont dupli…

d99bb46

…cate data" This reverts commit c5125d6.

Merge branch 'master' into enhancement/multi-module-with-reactor

8aaecc8

prevent simple mode from running in all modules

f2cedf7

jmecosta mentioned this pull request Jan 6, 2015

Bdd/multimodule test #359

Closed

prevent simple mode from running in all modules

c2c0503

prevent simple mode from running in all modules

07de281

normalize paths in report

0efd310

wenns modified the milestones: M 0.9.3, M 0.9.2 Jan 10, 2015

jmecosta modified the milestones: M 0.9.2, M 0.9.3 Jan 10, 2015

guwirth added this to the M 0.9.3 milestone Apr 12, 2015

guwirth mentioned this pull request Apr 12, 2015

What benefits are multi-module setups giving us #367

Closed

Jorge Costa added 2 commits April 12, 2015 21:44

merge issues

5358764

Merge remote-tracking branch 'upstream/master' into enhancement/multi…

7c7bca5

…-module-with-reactor Conflicts: sonar-cxx-plugin/src/test/java/org/sonar/plugins/cxx/compiler/CxxCompilerSensorTest.java

guwirth mentioned this pull request Apr 17, 2015

Milestone V0.9.3 #384

Closed

Jorge Costa added 3 commits April 17, 2015 22:02

add AMD64 to list of allowed platforms - win8.1 64 bit

84b99c0

add ignore to list

33c3dfd

add ignore to list

df64b10

add ignore to list

3840fda

Jorge Costa added 2 commits April 17, 2015 23:05

add ignore to list

7beaab9

add ignore to list

a2e6592

guwirth reviewed Apr 18, 2015
View reviewed changes

enabled test again, make paths relative in report to be able to run e…

139f504

…verywhere

Merge branch 'master' into enhancement/multi-module-with-reactor

61d0d8c

guwirth added a commit that referenced this pull request Apr 18, 2015

Merge pull request #358 from jmecosta/enhancement/multi-module-with-r…

5080011

…eactor Enhancement/multi module with reactor

guwirth merged commit 5080011 into SonarOpenCommunity:master Apr 18, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhancement/multi module with reactor #358

Enhancement/multi module with reactor #358

jmecosta commented Jan 4, 2015

wenns commented Jan 6, 2015

jmecosta commented Jan 6, 2015

jmecosta commented Jan 6, 2015

jmecosta commented Jan 6, 2015

wenns commented Jan 6, 2015

jmecosta commented Jan 6, 2015

jmecosta commented Jan 6, 2015

wenns commented Jan 10, 2015

guwirth commented Apr 12, 2015

Bertk commented Apr 12, 2015

jmecosta commented Apr 12, 2015

jmecosta commented Apr 17, 2015

guwirth commented Apr 17, 2015

guwirth Apr 18, 2015

jmecosta Apr 18, 2015

jmecosta commented Apr 18, 2015

guwirth commented Apr 18, 2015

jmecosta commented Apr 18, 2015

guwirth commented Apr 18, 2015

jmecosta commented Apr 18, 2015

guwirth commented Apr 18, 2015

jmecosta commented Apr 18, 2015

Enhancement/multi module with reactor #358

Enhancement/multi module with reactor #358

Conversation

jmecosta commented Jan 4, 2015

wenns commented Jan 6, 2015

jmecosta commented Jan 6, 2015

jmecosta commented Jan 6, 2015

jmecosta commented Jan 6, 2015

wenns commented Jan 6, 2015

jmecosta commented Jan 6, 2015

jmecosta commented Jan 6, 2015

wenns commented Jan 10, 2015

guwirth commented Apr 12, 2015

Bertk commented Apr 12, 2015

jmecosta commented Apr 12, 2015

jmecosta commented Apr 17, 2015

guwirth commented Apr 17, 2015

guwirth Apr 18, 2015

Choose a reason for hiding this comment

jmecosta Apr 18, 2015

Choose a reason for hiding this comment

jmecosta commented Apr 18, 2015

guwirth commented Apr 18, 2015

jmecosta commented Apr 18, 2015

guwirth commented Apr 18, 2015

jmecosta commented Apr 18, 2015

guwirth commented Apr 18, 2015

jmecosta commented Apr 18, 2015