Support SonarQube 10.x

[agebert]

The goal is to support SonarQube 10.x. It is based on #2613 and supersedes #2612.

With these changes you can use 10.x version of org.sonarsource.sonarqube:sonar-plugin-api-impl and
org.sonarsource.api.plugin:sonar-plugin-api .

I fixed all compile issues for new plug-in https://sonarsource.atlassian.net/browse/SONARTEXT-57 and Java 17.

I did not test the result.

Sorry for creating a new PR, but I wanted to rebase on top of #2613 and do not know how-to do this with an existing #2612.

---

This change is 

[guwirth]

Hi @agebert,

thanks a lot.

The CI is failing with SQ 10.3:
https://github.com/SonarOpenCommunity/sonar-cxx/actions/runs/7610795834
https://github.com/SonarOpenCommunity/sonar-cxx/actions/runs/7610795834/job/20725141097

Failing scenarios:
integration-tests/features/smoketest.feature:6 Smoketest UTF-8 (without BOM)
integration-tests/features/smoketest.feature:71 Smoketest UTF-8 (with BOM)
integration-tests/features/smoketest.feature:136 Smoketest UTF-16LE (with BOM)
integration-tests/features/smoketest.feature:201 Project using Bullseye coverage, xUnit, Cppcheck, Rats, Vera++

I have to look deeper into it what the reason is.

Regards,

[guwirth]

@agebert small question: are you using the plugin in your SQ 10.3 environment successful?

[agebert]

@guwirth no, I did not test it at all. I only run the "mvn verify".

We are new to SonarQube and picked SonarQube 10.x because it is faster than SonarQube 9.x for our setup. With SonarQube 10.3 we failed to use sonar-cxx 2.1 as explained on Compatibility-Matrix. On the other hand we downgraded to SonarQube 10.0, and this works with sonar-cxx 2.1.

Thank you and all contributes for this project.

It is fun to work with you @guwirth.

[guwirth]

Seems to be changes in the WebApi so that tests are no more running.

[agebert]

Can I help with something?

[guwirth]

Hi @agebert,

below the failing API requests:

Get measures with query : /api/measures/component?component=smoketest_project&metricKeys=ncloc,lines,statements,classes,files,directories,functions,comment_lines_density,comment_lines,duplicated_lines_density,duplicated_lines,duplicated_blocks,duplicated_files,complexity,cognitive_complexity,file_complexity,violations,lines_to_cover,coverage,line_coverage,branch_coverage,uncovered_conditions,uncovered_lines,tests,test_failures,test_errors,skipped_tests,test_execution_time,test_success_density,false_positive_issues,open_issues,confirmed_issues,reopened_issues,code_smells,sqale_index,sqale_debt_ratio,bugs,reliability_remediation_effort,vulnerabilities,security_remediation_effort,security_hotspots
      Assertion Failed: error web_api_get: http://localhost:9000/api/measures/component?component=smoketest_project&metricKeys=ncloc,lines,statements,classes,files,directories,functions,comment_lines_density,comment_lines,duplicated_lines_density,duplicated_lines,duplicated_blocks,duplicated_files,complexity,cognitive_complexity,file_complexity,violations,lines_to_cover,coverage,line_coverage,branch_coverage,uncovered_conditions,uncovered_lines,tests,test_failures,test_errors,skipped_tests,test_execution_time,test_success_density,false_positive_issues,open_issues,confirmed_issues,reopened_issues,code_smells,sqale_index,sqale_debt_ratio,bugs,reliability_remediation_effort,vulnerabilities,security_remediation_effort,security_hotspots -> 404 Client Error:  for url: http://localhost:9000/api/measures/component?component=smoketest_project&metricKeys=ncloc,lines,statements,classes,files,directories,functions,comment_lines_density,comment_lines,duplicated_lines_density,duplicated_lines,duplicated_blocks,duplicated_files,complexity,cognitive_complexity,file_complexity,violations,lines_to_cover,coverage,line_coverage,branch_coverage,uncovered_conditions,uncovered_lines,tests,test_failures,test_errors,skipped_tests,test_execution_time,test_success_density,false_positive_issues,open_issues,confirmed_issues,reopened_issues,code_smells,sqale_index,sqale_debt_ratio,bugs,reliability_remediation_effort,vulnerabilities,security_remediation_effort,security_hotspots
      
Get measures with query : /api/measures/component?component=smoketest_project_utf8_bom&metricKeys=ncloc,lines,statements,classes,files,directories,functions,comment_lines_density,comment_lines,duplicated_lines_density,duplicated_lines,duplicated_blocks,duplicated_files,complexity,cognitive_complexity,file_complexity,violations,lines_to_cover,coverage,line_coverage,branch_coverage,uncovered_conditions,uncovered_lines,tests,test_failures,test_errors,skipped_tests,test_execution_time,test_success_density,false_positive_issues,open_issues,confirmed_issues,reopened_issues,code_smells,sqale_index,sqale_debt_ratio,bugs,reliability_remediation_effort,vulnerabilities,security_remediation_effort,security_hotspots
      Assertion Failed: error web_api_get: http://localhost:9000/api/measures/component?component=smoketest_project_utf8_bom&metricKeys=ncloc,lines,statements,classes,files,directories,functions,comment_lines_density,comment_lines,duplicated_lines_density,duplicated_lines,duplicated_blocks,duplicated_files,complexity,cognitive_complexity,file_complexity,violations,lines_to_cover,coverage,line_coverage,branch_coverage,uncovered_conditions,uncovered_lines,tests,test_failures,test_errors,skipped_tests,test_execution_time,test_success_density,false_positive_issues,open_issues,confirmed_issues,reopened_issues,code_smells,sqale_index,sqale_debt_ratio,bugs,reliability_remediation_effort,vulnerabilities,security_remediation_effort,security_hotspots -> 404 Client Error:  for url: http://localhost:9000/api/measures/component?component=smoketest_project_utf8_bom&metricKeys=ncloc,lines,statements,classes,files,directories,functions,comment_lines_density,comment_lines,duplicated_lines_density,duplicated_lines,duplicated_blocks,duplicated_files,complexity,cognitive_complexity,file_complexity,violations,lines_to_cover,coverage,line_coverage,branch_coverage,uncovered_conditions,uncovered_lines,tests,test_failures,test_errors,skipped_tests,test_execution_time,test_success_density,false_positive_issues,open_issues,confirmed_issues,reopened_issues,code_smells,sqale_index,sqale_debt_ratio,bugs,reliability_remediation_effort,vulnerabilities,security_remediation_effort,security_hotspots
      
Get measures with query : /api/measures/component?component=smoketest_project_utf16&metricKeys=ncloc,lines,statements,classes,files,directories,functions,comment_lines_density,comment_lines,duplicated_lines_density,duplicated_lines,duplicated_blocks,duplicated_files,complexity,cognitive_complexity,file_complexity,violations,lines_to_cover,coverage,line_coverage,branch_coverage,uncovered_conditions,uncovered_lines,tests,test_failures,test_errors,skipped_tests,test_execution_time,test_success_density,false_positive_issues,open_issues,confirmed_issues,reopened_issues,code_smells,sqale_index,sqale_debt_ratio,bugs,reliability_remediation_effort,vulnerabilities,security_remediation_effort,security_hotspots
      Assertion Failed: error web_api_get: http://localhost:9000/api/measures/component?component=smoketest_project_utf16&metricKeys=ncloc,lines,statements,classes,files,directories,functions,comment_lines_density,comment_lines,duplicated_lines_density,duplicated_lines,duplicated_blocks,duplicated_files,complexity,cognitive_complexity,file_complexity,violations,lines_to_cover,coverage,line_coverage,branch_coverage,uncovered_conditions,uncovered_lines,tests,test_failures,test_errors,skipped_tests,test_execution_time,test_success_density,false_positive_issues,open_issues,confirmed_issues,reopened_issues,code_smells,sqale_index,sqale_debt_ratio,bugs,reliability_remediation_effort,vulnerabilities,security_remediation_effort,security_hotspots -> 404 Client Error:  for url: http://localhost:9000/api/measures/component?component=smoketest_project_utf16&metricKeys=ncloc,lines,statements,classes,files,directories,functions,comment_lines_density,comment_lines,duplicated_lines_density,duplicated_lines,duplicated_blocks,duplicated_files,complexity,cognitive_complexity,file_complexity,violations,lines_to_cover,coverage,line_coverage,branch_coverage,uncovered_conditions,uncovered_lines,tests,test_failures,test_errors,skipped_tests,test_execution_time,test_success_density,false_positive_issues,open_issues,confirmed_issues,reopened_issues,code_smells,sqale_index,sqale_debt_ratio,bugs,reliability_remediation_effort,vulnerabilities,security_remediation_effort,security_hotspots

Assertion Failed: error web_api_set: http://localhost:9000/api/rules/create {'custom_key': 'cpplint_legal_copyright_0', 'html_description': 'nodesc', 'name': 'cpplint_legal_copyright_0', 'severity': 'MAJOR', 'template_key': 'other:CustomRuleTemplate', 'markdown_description': 'nodesc'} -> 400 Client Error:  for url: http://localhost:9000/api/rules/create, {"errors":[{"msg":"The \u0027customKey\u0027 parameter is missing"}]}

These two API calls are failing:

• /api/measures/component
• /api/rules/create

Maybe API does no more exist or they changed the parameters? If you have time you can look into the documentation if you find something.

Regards,

[agebert]

I fixed the failing tests:

  integration-tests/features/smoketest.feature:6 Smoketest UTF-8 (without BOM)
  integration-tests/features/smoketest.feature:71 Smoketest UTF-8 (with BOM)
  integration-tests/features/smoketest.feature:136 Smoketest UTF-16LE (with BOM)
  integration-tests/features/smoketest.feature:201 Project using Bullseye coverage, xUnit, Cppcheck, Rats, Vera++

If I run it local I get this result:

Failing scenarios:
  integration-tests/features/compiler.feature:5  Import a VisualStudio LOG file with warnings

11 features passed, 1 failed, 0 skipped
36 scenarios passed, 1 failed, 2 skipped
321 steps passed, 1 failed, 12 skipped, 0 undefined
Took 12m16.770s

Details of the failed test

Feature: Importing compiler reports
  As a CXX plug-in user, I want to import LOG files from compilers into SonarQube
  Scenario: Import a VisualStudio LOG file with warnings
    Given the project "vs_project"
    And rule "compiler-vc:C4189" is activated
    And rule "compiler-vc:C4457" is activated
    And platform is "Windows"
    When I run sonar-scanner with "-X"
    Then the analysis finishes successfully
    And the analysis in server has completed
    And the server log (if locatable) contains no error/warning messages
    And the number of violations fed is 2
      Assertion Failed:
        violations is actually 0 [expected: 2.0]
      Captured stdout:
          Read Log : _vs_project_1.log
           Get Analysis In Background : http://localhost:9000/api/ce/task?id=AY1r9aNqECRYjJoRquI9
           CURRENT STATUS : IN_PROGRESS
           CURRENT STATUS : IN_PROGRESS
           CURRENT STATUS : SUCCESS

      Get measures with query : /api/measures/component?component=vs_project&metricKeys=violations

I don't know how-to fix this.

[guwirth]

Hi @agebert,

thanks for fixing the integration test.

violations is actually 0 [expected: 2.0]

Looks like the two rules are not activated on your local machine?

And rule "compiler-vc:C4189" is activated
And rule "compiler-vc:C4457" is activated

Do you have the corresponding rights on the server to change rule settings?

Regards,

[guwirth]

Hi @agebert,

build is running on CI
https://github.com/SonarOpenCommunity/sonar-cxx/actions/runs/7762444267
Resulting JAR
https://github.com/SonarOpenCommunity/sonar-cxx/actions/runs/7762444267/artifacts/1217094897

There is still a problem with CodeQL using the wrong Java version. actions/setup-java missing in https://github.com/SonarOpenCommunity/sonar-cxx/blob/master/.github/workflows/codeql-analysis.yml.

I will add the JAR files to the Releases as a beta so that others also can use it with SQ 10.

Regards,

[guwirth]

merged into branch SQ-10 and release as a first V2.2-beta

[agebert]

@guwirth thank you for merging and creating a beta version.