Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preprocessor refactoring #1984

Merged
merged 1 commit into from
Dec 3, 2020
Merged

preprocessor refactoring #1984

merged 1 commit into from
Dec 3, 2020

Conversation

guwirth
Copy link
Collaborator

@guwirth guwirth commented Dec 2, 2020 •
edited by SonarOpenCommunityAdmin
Loading

  1. In the same directory as the file that contains the #include statement.
  2. In the directories of the currently opened include files, in the reverse order in which they were opened. The search begins in the directory of the parent include file and continues upward through the directories of any grandparent include files.
  3. fallback to use include paths instead of local folder (same as Angle-bracket form)

This change is Reviewable

@guwirth guwirth added this to the 2.0.0 milestone Dec 2, 2020
@guwirth guwirth self-assigned this Dec 2, 2020
@guwirth
preprocessor refactoring
9477312 
- support Microsoft Quoted form search (close SonarOpenCommunity#1225):
1) In the same directory as the file that contains the #include statement.
2) In the directories of the currently opened include files, in the reverse order in which they were opened. The search begins in the directory  of the parent include file and continues upward through the directories of any grandparent include files.
3) fallback to use include paths instead of local folder (same as Angle-bracket form)

- add #include unit tests
- test for compilation database settings propagation (close SonarOpenCommunity#1489)
- refactoring
@ghost
Copy link

ghost commented Dec 3, 2020

DeepCode's analysis on #947731 found:

  • ℹ️ 1 minor issue. 👇
  • ✔️ 1 issue was fixed.

Top issues

Description Example fixes
Use java.util.ArrayList instead of java.util.LinkedList. Using java.util.LinkedList can lead to unnecessary performance overhead if the list is randomly accessed. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@guwirth guwirth merged commit 7cddbf7 into SonarOpenCommunity:master Dec 3, 2020
@guwirth guwirth deleted the preprocessor-fixes branch January 31, 2021 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@guwirth guwirth

Labels
enhancement
Milestone
2.0.0
1 participant
@guwirth