Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support cppcheck 1.85 #1576

Merged
merged 1 commit into from
Oct 17, 2018
Merged

Conversation

ivangalkin
Copy link
Contributor

@ivangalkin ivangalkin commented Oct 15, 2018

The following new rules were introduced:

Rule SonarQube severity cppcheck severity
Qstring::sprintfCalled MINOR CODE_SMELL style
containerOutOfBounds MAJOR BUG error
incorrectCharBooleanError MINOR BUG warning
mismatchingContainerExpression MINOR BUG warning
sameIteratorExpression MINOR CODE_SMELL style
useStlAlgorithm MINOR CODE_SMELL style
wxString::StripCalled MINOR CODE_SMELL style

Fixes #1545


This change is Reviewable

The following new rules were introduced:

| Rule                           | SonarQube severity | cppcheck severity |
|--------------------------------|--------------------|-------------------|
| Qstring::sprintfCalled         | MINOR CODE_SMELL   | style             |
| containerOutOfBounds           | MAJOR BUG          | error             |
| incorrectCharBooleanError      | MINOR BUG          | warning           |
| mismatchingContainerExpression | MINOR BUG          | warning           |
| sameIteratorExpression         | MINOR CODE_SMELL   | style             |
| useStlAlgorithm                | MINOR CODE_SMELL   | style             |
| wxString::StripCalled          | MINOR CODE_SMELL   | style             |

Fixes SonarOpenCommunity#1545
@ivangalkin ivangalkin added this to the 1.2 milestone Oct 15, 2018
@ivangalkin ivangalkin self-assigned this Oct 15, 2018
@guwirth
Copy link
Collaborator

guwirth commented Oct 17, 2018

@ivangalkin don't know if we should not also do "Refactoring: CppCheck rules cleanup #1247". Proposal is to support only 1.80+ and remove older rules?

@ivangalkin
Copy link
Contributor Author

@guwirth I'll comment on the #1247. In short - I tend to disagree to the suggested cleanup.

@guwirth guwirth merged commit be53b44 into SonarOpenCommunity:master Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants