Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clang-tidy rules; Tune severities #1558

Merged

Conversation

ivangalkin
Copy link
Contributor

@ivangalkin ivangalkin commented Sep 21, 2018

Apply custom severities, suggested by @nathanaelg

ATTENTION! severity of the following exiting rule was lowered

  • cppcoreguidelines-no-malloc

please review!

misc: original documentation contained internal hyperlinks, change them to external ones

#1536 ( still doesn't close the issue, we need more rules mentioned in #1560)


This change is Reviewable

* apply custom severities, suggested by @nathanaelg
* ATTENTION! severity of the following exiting rule was lowered
  ** cppcoreguidelines-no-malloc
* please review!

ALSO: original documentation contained internal hyperlinks
      change them to external ones
@guwirth
Copy link
Collaborator

guwirth commented Sep 23, 2018

@nathanaelg please add also your comments

@nathanaelg
Copy link
Contributor

nathanaelg commented Sep 23, 2018

I had put cppcoreguidelines-no-malloc as info code smell because it was one of the "don't use this feature of the language" even though if you use it properly it isn't necessarily problematic.

On further thought though, it is one of those things that is fairly easy to get wrong and the consequences are fairly bad so might be best to have it as a major code smell - I'm still not convinced it should be classed as a bug rather than code smell.

Also, if you do change it, hicpp-no-malloc should match as it is an alias.

@guwirth guwirth merged commit c9609aa into SonarOpenCommunity:master Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants