Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1516 - protect ExpressionEvaluator from self-referential macros #1517

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Fix #1516 - protect ExpressionEvaluator from self-referential macros #1517

merged 1 commit into from
Jul 18, 2018

Conversation

ivangalkin
Copy link
Contributor

@ivangalkin ivangalkin commented Jul 11, 2018 •
edited by guwirth
Loading

  • ExpressionEvaluator: introduce evaluation stack in order to
    terminate an endless recursion
  • CxxPreprocessor: don't cache ExpressionEvaluator in order to
    reset the evaluation stack properly
  • fix ExpressionEvaluatorTest
  • introduce new tests

close #1516

This change is Reviewable

@ivangalkin
Fix SonarOpenCommunity#1516 - protect ExpressionEvaluator from self-r…
13159ea 
…eferential macros

* `ExpressionEvaluator`: introduce evaluation stack in order to
  terminate an endless recursion
* `CxxPreprocessor`: don't cache `ExpressionEvaluator` in order to
  reset the evaluation stack properly
* fix `ExpressionEvaluatorTest`
* introduce new tests
@ivangalkin ivangalkin requested review from guwirth and Bertk July 11, 2018 15:40
Bertk
Bertk approved these changes Jul 16, 2018
View reviewed changes
Copy link
Contributor

@Bertk Bertk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@guwirth guwirth added this to the 1.2 milestone Jul 18, 2018
@guwirth guwirth added the bug label Jul 18, 2018
@guwirth guwirth merged commit e082c4a into SonarOpenCommunity:master Jul 18, 2018
@ivangalkin ivangalkin mentioned this pull request Sep 3, 2018
Closed
@guwirth guwirth mentioned this pull request Nov 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guwirth guwirth guwirth approved these changes

@Bertk Bertk Bertk approved these changes

Assignees

@ivangalkin ivangalkin

Labels
bug
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

java.lang.StackOverflowError during parse of source file
3 participants
@ivangalkin @Bertk @guwirth