Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support cppcheck 1.84 (see #1490) #1495

Merged
merged 1 commit into from
Jun 15, 2018

Conversation

ivangalkin
Copy link
Contributor

@ivangalkin ivangalkin commented Jun 13, 2018

new rules

  • QString::sprintfCalled (style / obsolete function)
  • QString::vsprintfCalled (style / obsolete function)
  • asctime_sCalled (style / obsolete function)
  • duplicateValueTernary (style)
  • identicalInnerCondition (warning)
  • missingOverride (style)
  • noDestructor (style)
  • noOperatorEq (style)
  • oppositeExpression (style)
  • pureVirtualCall (warning)
  • qInstallMsgHandlerCalled (style / obsolete function)
  • qrandCalled (style / obsolete function)
  • qsrandCalled (style / obsolete function)
  • std::asctime_sCalled (style / obsolete function)
  • umaskCalled (style / obsolete function)
  • virtualCallInConstructor (warning)

PLEASE double-check the resulting SonarQube severities:

  • style -> MINOR CODE_SMELL
  • warning -> MINOR BUG

corrected rules desrciptions

  • terminateStrncpy
  • noCopyConstructor
  • nullPointerArithmetic
  • passedByValue
  • derefInvalidIterator

This change is Reviewable

new rules
* `QString::sprintfCalled     (style / obsolete function)`
* `QString::vsprintfCalled    (style / obsolete function)`
* `asctime_sCalled            (style / obsolete function)`
* `duplicateValueTernary      (style)`
* `identicalInnerCondition    (warning)`
* `missingOverride            (style)`
* `noDestructor               (style)`
* `noOperatorEq               (style)`
* `oppositeExpression         (style)`
* `pureVirtualCall            (warning)`
* `qInstallMsgHandlerCalled   (style / obsolete function)`
* `qrandCalled                (style / obsolete function)`
* `qsrandCalled               (style / obsolete function)`
* `std::asctime_sCalled       (style / obsolete function)`
* `umaskCalled                (style / obsolete function)`
* `virtualCallInConstructor   (warning)`

PLEASE double-check the resulting SonarQube severities:

* style -> MINOR CODE_SMELL
* warning -> MINOR BUG

corrected rules desrciptions
* `terminateStrncpy`
* `noCopyConstructor`
* `nullPointerArithmetic`
* `passedByValue`
* `derefInvalidIterator`
Copy link
Collaborator

@guwirth guwirth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivangalkin looks good, thx.

@guwirth guwirth added this to the 1.1 milestone Jun 15, 2018
@guwirth guwirth merged commit 151199a into SonarOpenCommunity:master Jun 15, 2018
@guwirth
Copy link
Collaborator

guwirth commented Jun 15, 2018

close #1490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants