sort checks #1487
Merged
sort checks #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- first step for #1410
|
@guwirth This cleanup will remove some checks which are useful and I do not know a replacement e.g. for „SafetyTagCheck.java". The other tools do not provide all of these checkers but I am not aware of the latest version of some commercial tools. |
@Bertk SafetyTagCheck looks like a very company specific check and not a general check? Is the plugin really the right place for it or shouldn’t it be better moved to a custom check? |
|
@ALL I will add this PR to sort the checks in subfolders. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step for #1410. Please have a look to this. Is a first proposal how to sort the checks.
For my understanding checks below are static code analysis and can be removed:
Some of the regex checks are duplicates:
How should we continue?
This change is