Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis.yml: execute automatic HTML checks for rules files #1467

Merged
merged 1 commit into from
Apr 27, 2018

Conversation

ivangalkin
Copy link
Contributor

@ivangalkin ivangalkin commented Apr 25, 2018

This change is Reviewable

@ivangalkin
Copy link
Contributor Author

See below the snipped from travis log.

BTW: I realized, that cxx-sensors/src/main/resources/external/intel_inspector_rules.xml is not a valid rules file. Is it transformed somehow? What is it good for?

$ bash cxx-sensors/src/tools/check_rules.sh
[ PASSED ] /home/travis/build/SonarOpenCommunity/sonar-cxx/cxx-sensors/src/main/resources/clangsa.xml
[ PASSED ] /home/travis/build/SonarOpenCommunity/sonar-cxx/cxx-sensors/src/main/resources/clangtidy.xml
[ PASSED ] /home/travis/build/SonarOpenCommunity/sonar-cxx/cxx-sensors/src/main/resources/compiler-gcc.xml
[ PASSED ] /home/travis/build/SonarOpenCommunity/sonar-cxx/cxx-sensors/src/main/resources/compiler-vc.xml
[ PASSED ] /home/travis/build/SonarOpenCommunity/sonar-cxx/cxx-sensors/src/main/resources/cppcheck.xml
[ PASSED ] /home/travis/build/SonarOpenCommunity/sonar-cxx/cxx-sensors/src/main/resources/drmemory.xml
[ PASSED ] /home/travis/build/SonarOpenCommunity/sonar-cxx/cxx-sensors/src/main/resources/external-rule.xml
[ PASSED ] /home/travis/build/SonarOpenCommunity/sonar-cxx/cxx-sensors/src/main/resources/pclint.xml
[ PASSED ] /home/travis/build/SonarOpenCommunity/sonar-cxx/cxx-sensors/src/main/resources/rats.xml
[ PASSED ] /home/travis/build/SonarOpenCommunity/sonar-cxx/cxx-sensors/src/main/resources/valgrind.xml
[ PASSED ] /home/travis/build/SonarOpenCommunity/sonar-cxx/cxx-sensors/src/main/resources/vera++.xml
The command "bash cxx-sensors/src/tools/check_rules.sh" exited with 0.

Done in 8.81s

@guwirth guwirth added this to the 1.0 milestone Apr 26, 2018
@guwirth
Copy link
Collaborator

guwirth commented Apr 26, 2018

I realized, that cxx-sensors/src/main/resources/external/intel_inspector_rules.xml is not a valid rules file. Is it transformed somehow? What is it good for?

@ivangalkin these are (were) the rules for the Intel Inspector and can be used as part of the "other" sensor to handle these issues. Seems no one is using it: you can remove it.

@ivangalkin
Copy link
Contributor Author

@guwirth now I see, there is much infrastructure around such "other" reports, rules, transformations, tests etc. Although intel_inspector_rules.xml is not referenced directly, but it looks like (theoretically) somebody could make use of it.

It remembers me a bit on generic coverage or generic test results. So in general the idea is not bad IMHO.

@guwirth
Copy link
Collaborator

guwirth commented Apr 27, 2018

It remembers me a bit on generic coverage or generic test results. So in general the idea is not bad IMHO.

The generic test and coverage sensors are new in the SQ core, before they were in extra plugins. A generic solution could be to provide a XSLT mechanism outside the sensors (so the current other location is not the best place). We have somehow to ensure that XSLT is executed before all sensors. This mechanism could be used for test, covergage, other, ... then

@guwirth
Copy link
Collaborator

guwirth commented Apr 27, 2018

intel_inspector_rules.xml is not a valid rules file.

@ivangalkin In case the whole file is no more valid I would remove it: not maintained means not used.

@ivangalkin
Copy link
Contributor Author

please see #1470

@guwirth guwirth merged commit b130565 into SonarOpenCommunity:master Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants