refactor CxxFileLinesVisitorTest #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- only one assert per test - add constexpr in test file "ncloc.cc"
- show hits and condition per line - remove obsolete test
- conditional coverage is not supported with Microsoft coverage data
|
Solves issue #1425 |
guwirth
reviewed
Feb 24, 2018
| @@ -122,7 +119,6 @@ private static void collectRangeMeasures(SMInputCursor function, Map<String, Cov | |||
| coverageData.put(sourceId, builder); | |||
| } | |||
|
|
|||
| builder.setConditions(startLine - 1, conditions, coveredConditions); | |||
There was a problem hiding this comment.
@Bertk don't understand why this is no more needed?
There was a problem hiding this comment.
There are 2 issues with this line:
- The calculation
startLine - 1creates measures for wrong code lines - Microsoft coverage tool only provides block coverage but not branch coverage (selection statements). The indicator for partial covered condition cannot be set for the relevant code line but only for the code block and the code metric shows more conditions for a source file than conditions exists in the file itself.
A compromise is to remove the calculation and set condition for every block but this is a different way Visual Studio does it and should be avoided.
There was a problem hiding this comment.
The solution with the compromise produces this output:
|
@Bertk does this still fit to description in rdwiki https://github.com/SonarOpenCommunity/sonar-cxx/wiki/Get-code-coverage-metrics? |
|
@guwirth I updated the page and removed the invalid parts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is