Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix quality flaws #1414

Merged
merged 3 commits into from
Jan 28, 2018
Merged

fix quality flaws #1414

merged 3 commits into from
Jan 28, 2018

Conversation

Bertk
Copy link
Contributor

@Bertk Bertk commented Jan 28, 2018 •
edited by SonarOpenCommunityAdmin
Loading

  • improve assert statements in tests
  • use unique names for constants
  • suppress warnings

This change is Reviewable

@Bertk Bertk self-assigned this Jan 28, 2018
@Bertk Bertk requested a review from guwirth January 28, 2018 17:15
@guwirth guwirth added this to the 1.0 milestone Jan 28, 2018
@guwirth guwirth merged commit f10e60b into SonarOpenCommunity:master Jan 28, 2018
@Bertk Bertk deleted the bugfix branch February 3, 2018 07:11
@guwirth guwirth mentioned this pull request May 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guwirth guwirth guwirth approved these changes

Assignees

@Bertk Bertk

Labels
enhancement
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Bertk @guwirth