Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cppcheck 1.82 (new rules) #1373

Merged
merged 1 commit into from
Jan 4, 2018
Merged

cppcheck 1.82 (new rules) #1373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 49 additions & 3 deletions cxx-sensors/src/main/resources/cppcheck.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5799,10 +5799,10 @@ Result of operator '|' is always true if one operand is non-zero. Did you intend
</rule>
<rule>
<key>knownConditionTrueFalse</key>
<name>Condition &apos;x&apos; is always true</name>
<name>Condition &apos;x&apos; is always true or false</name>
<description>
<![CDATA[<p>
Condition 'x' is always true.
Condition 'x' is always true or false.
</p><h2>References</h2>
<p><a href="https://cwe.mitre.org/data/definitions/570.html" target="_blank">CWE-570: Expression is Always False</a></p>
<p><a href="https://cwe.mitre.org/data/definitions/571.html" target="_blank">CWE-571: Expression is Always True</a></p>
Expand Down Expand Up @@ -5976,7 +5976,7 @@ Boolean value assigned to floating point variable.
<name>Invalid test for overflow (undefined behavior)</name>
<description>
<![CDATA[<p>
Invalid test for overflow 'x + u < x'. Condition is always false unless there is overflow, and overflow is UB.
Invalid test for overflow 'x + u < x'. Condition is always false unless there is overflow, and overflow is undefined behaviour.
</p><h2>References</h2>
<p><a href="https://cwe.mitre.org/data/definitions/570.html" target="_blank">CWE-570: Expression is Always False</a></p>
]]>
Expand Down Expand Up @@ -6299,6 +6299,52 @@ The class 'class' has 'operator=' but lack of 'copy constructor'.
<remediationFunction>LINEAR</remediationFunction>
<remediationFunctionGapMultiplier>5min</remediationFunctionGapMultiplier>
</rule>
<!-- ########### New in cppcheck 1.82 ########### -->
<rule>
<key>unsafeClassDivZero</key>
<name>Public interface of Class is not safe</name>
<description>
<![CDATA[<p>
Public interface of Class is not safe. When calling Class::dostuff(), if parameter 'x' is 0 that leads to division by zero.
</p>
]]>
</description>
<internalKey>unsafeClassDivZero</internalKey>
<severity>MINOR</severity>
<type>CODE_SMELL</type>
<remediationFunction>LINEAR</remediationFunction>
<remediationFunctionGapMultiplier>5min</remediationFunctionGapMultiplier>
</rule>
<rule>
<key>pointerAdditionResultNotNull</key>
<name>Comparison is wrong. Result of &apos;ptr+1&apos; can&apos;t be 0</name>
<description>
<![CDATA[<p>
Comparison is wrong. Result of 'ptr+1' can't be 0 unless there is pointer overflow, and pointer overflow is undefined behaviour.
</p>
]]>
</description>
<internalKey>pointerAdditionResultNotNull</internalKey>
<severity>MAJOR</severity>
<type>CODE_SMELL</type>
<remediationFunction>LINEAR</remediationFunction>
<remediationFunctionGapMultiplier>5min</remediationFunctionGapMultiplier>
</rule>
<rule>
<key>overlappingStrcmp</key>
<name>Multiple suspicious overlapping strcmp</name>
<description>
<![CDATA[<p>
The expression 'strcmp(x,"def") != 0' is suspicious. It overlaps 'strcmp(x,"abc") == 0'.
</p>
]]>
</description>
<internalKey>overlappingStrcmp</internalKey>
<severity>MINOR</severity>
<type>CODE_SMELL</type>
<remediationFunction>LINEAR</remediationFunction>
<remediationFunctionGapMultiplier>1min</remediationFunctionGapMultiplier>
</rule>
<!-- ########### add missing rules which seems not to be part of cppcheck errorlist ########### -->
<rule>
<key>asctimeCalled</key>
Expand Down
2 changes: 1 addition & 1 deletion cxx-sensors/src/test/java/org/sonar/cxx/sensors/cppcheck/CxxCppCheckRuleRepositoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,6 @@ public void createRulesTest() {
def.define(context);

RulesDefinition.Repository repo = context.repository(CxxCppCheckRuleRepository.KEY);
assertEquals(376, repo.rules().size());
assertEquals(379, repo.rules().size());
}
}