Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Technical Debt: fix quality flaws #1349

Merged
merged 5 commits into from
Dec 3, 2017
Merged

Technical Debt: fix quality flaws #1349

merged 5 commits into from
Dec 3, 2017

Commits on Dec 2, 2017

  1. Method needlessly boxes a boolean constant 

    fb-contrib:NAB_NEEDLESS_BOOLEAN_CONSTANT_CONVERSION
    @Bertk
    Bertk committed Dec 2, 2017
    Configuration menu
    Copy the full SHA
    d61e071 View commit details
    Browse the repository at this point in the history

  2. Performance - Method uses a FileInputStream constructor 

    fb-contrib:IOI_USE_OF_FILE_STREAM_CONSTRUCTORS
    @Bertk
    Bertk committed Dec 2, 2017
    Configuration menu
    Copy the full SHA
    efdacdb View commit details
    Browse the repository at this point in the history

  3. Mutable members should not be stored or returned directly 

    squid:S2384
    @Bertk
    Bertk committed Dec 2, 2017
    Configuration menu
    Copy the full SHA
    4cb1435 View commit details
    Browse the repository at this point in the history

  4. use java 8 stream to read text file

    @Bertk
    Bertk committed Dec 2, 2017
    Configuration menu
    Copy the full SHA
    2b98747 View commit details
    Browse the repository at this point in the history

  5. pmd:UnnecessaryFullyQualifiedName

    @Bertk
    Bertk committed Dec 2, 2017
    Configuration menu
    Copy the full SHA
    e0c81cb View commit details
    Browse the repository at this point in the history