-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use SQ API 6.7 #1291
use SQ API 6.7 #1291
Conversation
@Bertk like to release 0.9.8 first. Will shift review after release... |
OK. The CI checks are failing and I disabled feature "Importing Cppcheck ANSI-C reports" .
I declared the header and source file extension as multivalue and the syntax of the request changed. |
29da60c
to
19c9b07
Compare
- 2 coverage unit tests are failing (now disabled) - sslr-cxx-toolkit build fails (INVOKESPECIAL/STATIC interfaces require ASM 5) - integration tests not checked fix coverage unit tests update version to 0.9.9 fix optinal and unit tests
- dotnet.tests.UnitTestResultsAggregator not compatible with org.sonar.api.config.Configuration
- replace org.fest.assertions.Assertions with org.assertj.core.api - remove sonar-dotnet-tests-library
avoid warnings and add log messages Fix messages like: WARNING: WARN: Property 'sonar.cxx.vera.reportPath' is not declared as multi-values/property set but was read using 'getStringArray' method. The SonarQube plugin declaring this property should be updated. cleanup of quality flaws remove warnings and error messages
reduce size of CXX sslr toolkit - remove includes - fix some issues
fix unit tests and clean-up fix typo more version id updates use SQ 6.7 API and use list of files for coverage
drop details for exception - disable failing API call enable importing_cppcheck_reports_c_cpp test fix python for loop use dictionary correct way
- check later
setting file extension does not work 11:55:23.348 ERROR: Error during SonarQube Scanner execution Language of file 'src\component1.h' can not be decided as the file matches patterns of both sonar.lang.patterns.c++ : **/*.cpp,**/*.cc,**/*.hxx,**/*.hpp,**/*.hh,**/*.h and sonar.lang.patterns.c : **/*.c,**/*.h
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bertk thx was for sure a lot of work. Think is a good starting point for v0.9.9. Code looks good let’s see what SQ is saying :-). I did no functional test only a code review.
@ALL someone else wanna review it? |
@guwirth Cleanup is still not completed and will be addressed with a another PR. |
#1272
This change is