Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use SQ API 6.7 #1291

Merged
merged 10 commits into from
Nov 19, 2017
Merged

use SQ API 6.7 #1291

merged 10 commits into from
Nov 19, 2017

Conversation

Bertk
Copy link
Contributor

@Bertk Bertk commented Nov 7, 2017

#1272


This change is Reviewable

@Bertk Bertk requested a review from guwirth November 7, 2017 22:27
@Bertk Bertk self-assigned this Nov 7, 2017
@Bertk Bertk changed the title use SQ API 6.6 use SQ API 6.7 Nov 8, 2017
@guwirth
Copy link
Collaborator

guwirth commented Nov 8, 2017

@Bertk like to release 0.9.8 first. Will shift review after release...

@Bertk
Copy link
Contributor Author

Bertk commented Nov 8, 2017

OK. The CI checks are failing and I disabled feature "Importing Cppcheck ANSI-C reports" .

      Assertion Failed: error _rest_api_set: http://localhost:9000/api/settings/set -> 400 Client Error:  for url: http://localhost:9000/api/settings/set

I declared the header and source file extension as multivalue and the syntax of the request changed.

@Bertk Bertk force-pushed the SQAPI6.5 branch 2 times, most recently from 29da60c to 19c9b07 Compare November 12, 2017 17:26
@guwirth guwirth added this to the next milestone Nov 14, 2017
- 2 coverage unit tests are failing (now disabled)
- sslr-cxx-toolkit build fails (INVOKESPECIAL/STATIC interfaces require
ASM 5)
- integration tests not checked

fix coverage unit tests

update version to 0.9.9

fix optinal and unit tests
- dotnet.tests.UnitTestResultsAggregator not compatible with
org.sonar.api.config.Configuration
- replace org.fest.assertions.Assertions with org.assertj.core.api
- remove sonar-dotnet-tests-library
avoid warnings and add log messages

Fix messages like:
WARNING: WARN: Property 'sonar.cxx.vera.reportPath' is not declared as
multi-values/property set but was read using 'getStringArray' method.
The SonarQube plugin declaring this property should be updated.

cleanup of quality flaws

remove warnings and error messages
reduce size of CXX sslr toolkit

- remove includes
- fix some issues
fix unit tests and clean-up

fix typo

more version id updates

use SQ 6.7 API and use list of files for coverage
drop details for exception - disable failing API call

enable importing_cppcheck_reports_c_cpp test

fix python for loop

use dictionary correct way
- check later
setting file extension does not work

11:55:23.348 ERROR: Error during SonarQube Scanner execution
Language of file 'src\component1.h' can not be decided as the file
matches patterns of both sonar.lang.patterns.c++ :
**/*.cpp,**/*.cc,**/*.hxx,**/*.hpp,**/*.hh,**/*.h and
sonar.lang.patterns.c : **/*.c,**/*.h
Copy link
Collaborator

@guwirth guwirth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bertk thx was for sure a lot of work. Think is a good starting point for v0.9.9. Code looks good let’s see what SQ is saying :-). I did no functional test only a code review.

@guwirth
Copy link
Collaborator

guwirth commented Nov 19, 2017

@ALL someone else wanna review it?

@Bertk
Copy link
Contributor Author

Bertk commented Nov 19, 2017

@guwirth Cleanup is still not completed and will be addressed with a another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants