parse Clang Static Analyzer plist reports

[gyorb]

Add support to parse Clang Static Analyzer plist results:

• reports can be parsed from v3.7 and up (checker name is available since that version in the plist reports)
• rules list is generated based on Clang v4.0.
• simple unit tests are added

Resolves #547

---

This change is 

[guwirth]

@gyorb thanks for your contribution. We will review it...

[guwirth]

@wichtounet think that's the feature you were looking for. Maybe you have also some time to try it out...

[wichtounet]

Hi,

Thanks for this contribution 👍

I just installed this on my sonar instance and try to test it. But I seen one big problem. Unless I'm mistaken, you have to set the path of a single plist file, right ? How do you to handle the use of scan-build ? scan-build generates a set of plist files in a folder.

If you don't plan to support scan-build, could you tell me how to use the static-analyzer with several threads?

Thanks :)

[gyorb]

Hi,

I've tested the plugin with scan-build and it can parse multiple plist files. The trick is to configure an ant-style glob pattern as a reportPath like this:
sonar.cxx.clangsa.reportPath=clang_reports/scan-build-2017-06-09-16-20-04-481327/*.plist

I've used this scan-build and Clang v3.8 for testing.

I wanted to create a wiki section on how to analyze a project and import the results, after the new feature is accepted.

I found a SampleProject2 should I update the documentation there too?

[wichtounet]

Ok, perfect. I didn't think of trying that. I used:

sonar.cxx.clangsa.reportPath=tmp/*/*.plist

And it worked well. I tested the official scan-build only.

It had to force alpha checkers to find issues in my programs. The analysis worked fine and the three warnings from the clang-static-analyzer were correctly reported in Sonar.

For me, it seems to work quite well. I don't have projects with lots of violations of static-analyzer, so cannot really test with large number of errors .

[guwirth]

@gyorb looks good to me. Think two additional things are missing:

• add documentation in wiki
• add an integration sample

[guwirth]

integration test:

• sample project should be here https://github.com/SonarOpenCommunity/sonar-cxx/tree/master/integration-tests/testdata
  • clangsa_project
• script should be here: https://github.com/SonarOpenCommunity/sonar-cxx/tree/master/integration-tests/features
  • importing_clangsa_reports.feature
• use cppcheck as sample: https://github.com/SonarOpenCommunity/sonar-cxx/blob/master/integration-tests/features/importing_cppcheck_reports.feature

[guwirth]

@gyorb do you work on integration test or should we merge it as is?

[gyorb]

@guwirth I had some other things to do and I did not finish the integration tests yet. I hope I can finish them soon.

[guwirth]

@gyorb I merge this so other has the chance to try it.

[gyorb]

@gyorb looks good to me. Think two additional things are missing:

• add documentation in wiki
• add an integration sample

@guwirth thanks for the review. I've added the integration tests in pr #1172 and extended the wiki about the analysis here and about the configuration here.

[guwirth]

@gyorb thx for providing detailed documentation how to use the feature.