move sensors to own library #1099
Conversation
|
@guwirth this is a initial implementation. for now only preparatory work to take the sensors out into a reusable library. once this is ready i will create a dedicated pr for c plugin |
jmecosta
force-pushed
the
feature/split-c-into-own-plugin
branch
from
ec3434f
to
083deac
Compare
move files move project builder
jmecosta
force-pushed
the
feature/split-c-into-own-plugin
branch
from
5d9c6b2
to
e11c793
Compare
|
@guwirth this is ready, i think |
|
massive refactoring, without touching integration tests and everything works :) |
|
@jmecosta Sounds good will have a look... |
|
@jmecosta looking over the code without testing it it looks good.
|
| @@ -293,4 +334,11 @@ private int saveViolations(InputFile inputFile, SourceFile squidFile, SensorCont | |||
| public String toString() { | |||
| return getClass().getSimpleName(); | |||
| } | |||
|
|
|||
| //@Override | |||
| //public List<Metric> getMetrics() { | |||
|
|
||
| @Override | ||
| public String[] getFileSuffixes() { | ||
| return new String [] {"cpp", "hpp", "h", "hxx", "cxx"}; |
There was a problem hiding this comment.
is getSourceFileSuffixes + getHeaderFileSuffixes?
There was a problem hiding this comment.
yep, but it takes less code to do this. we on the next pr we should clarify a bit better this behaviour
| @@ -48,7 +50,7 @@ public void test() { | |||
| RulesDefinition.Repository repository = context.repository(REPOSITORY_KEY); | |||
|
|
|||
| assertThat(repository.name()).isEqualTo(REPOSITORY_NAME); | |||
| assertThat(repository.language()).isEqualTo(CxxLanguage.KEY); | |||
| assertThat(repository.language()).isEqualTo("c++"); | |||
There was a problem hiding this comment.
'c++' hard coded. Is there no function?
| @@ -167,7 +177,7 @@ | |||
| private static List<PropertyDefinition> codeAnalysisProperties() { | |||
| String subcateg = "(2) Code analysis"; | |||
| return new ArrayList<>(Arrays.asList( | |||
| PropertyDefinition.builder(CxxCppCheckSensor.REPORT_PATH_KEY) | |||
| PropertyDefinition.builder("sonar.cxx." + CxxCppCheckSensor.REPORT_PATH_KEY) | |||
There was a problem hiding this comment.
hard coded string 'sonar.cxx': better use a constant
|
@guwirth this pr should not introduce any regression. this is meant only as a preparatory work to introduce the c plugin. That will go in once this is merged. when we have the c plugin, the only regression ive identified was related with "sonar.cxx.suffixes.sources" and headers, basically if we dont change the prop name then all users that use both plugin will need to manually modify their values to remove the c extensions. if changing the name of the prop and include only the c++ prefix then you are forcing people to use the 2 plugins. For me to reduce regression, i would not change the prop nor the prefix. And mention in documentation that if a c plugin is to be used then you must update the default extensions in the c++ plugin only to include c++ extensions. |
|
@guwirth should i merge then? |
|
Yes, would merge. Makes it easier to continue.
|
separate all sensors into own library, connect the cxx plugin to it.