Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Clang-Tidy error #1088

Merged
merged 1 commit into from
Mar 11, 2017
Merged

fix Clang-Tidy error #1088

merged 1 commit into from
Mar 11, 2017

Conversation

jmecosta
Copy link
Member

@jmecosta jmecosta commented Mar 10, 2017 •
edited by guwirth
Loading

Fix for #1076

@jmecosta jmecosta mentioned this pull request Mar 10, 2017
Closed
@guwirth guwirth changed the title fix error fix Clang-Tidy error Mar 11, 2017
@guwirth guwirth added this to the 0.9.8 milestone Mar 11, 2017
@guwirth guwirth added the bug label Mar 11, 2017
@guwirth
Copy link
Collaborator

guwirth commented Mar 11, 2017

@jmecosta wouldn't it be better

  • to use first the part before the first :
  • check if file path, normalize
  • and the parse the rest of the line?

@guwirth guwirth merged commit c1cf28d into SonarOpenCommunity:master Mar 11, 2017
@jmecosta
Copy link
Member Author

@guwirth nevermind, i can make it all with a single regular expression. That would be:

(.+|[a-zA-Z]:\.+):([0-9]+):([0-9]+): ([^:]+): ([^]]+)

@guwirth guwirth mentioned this pull request Oct 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jmecosta jmecosta

Labels
bug
Milestone
0.9.8
Development

Successfully merging this pull request may close these issues.
2 participants
@jmecosta @guwirth