Refactoring: AST parser errors not enough verbose.

[jmecosta]

We have things like this:

19:33:09.634 ERROR - Parse error at line 298 column 30:

290: (char *)s_GetTranslationCB(message));
291: else
292: result = s_CancelDialog.SetProgressTextCB(nbar, 0 );
293: }
294:
295: return result;
296: }
297:
--> int cncl_set_progress_pos(int NumberOfBar, int PercentCompleted)
299: {
300: int Result = 0;
301: static int sLastDisplayed = -1;
302:
303:
304:
305:
306: if(PercentCompleted < 0 || PercentCompleted > 100)
307: {

Have no idea why this is failing. earlier the stack trace of the parser failure was more informative than its now. Shouldnt it be better to have more info than less

[jmecosta]

In fact the message present by the rule is even redundant when looking in web ui since those are contextualized along with source code.

[guwirth]

Fixed with #484?

[guwirth]

Improve verbosity of parser in case of error is an enhancement => next version

[jmecosta]

Ok

On Thu, Apr 23, 2015, 10:34 Günter Wirth [email protected] wrote:

Improve verbosity of parser in case of error is an enhancement => next
version

—
Reply to this email directly or view it on GitHub
#476 (comment).

[guwirth]

Maybe add somehow AstXmlPrinter to ParsingErrorCheck?

package com.sonar.sslr.impl.ast;
AstXmlPrinter.print(astNode)

[guwirth]

Don't know if this is the right way but found this in JavaScript plugin. They seem to create a syntax/grammar tree and use it for more detailed output. Looks a little bit more complicated?

https://github.com/SonarCommunity/sonar-javascript/blob/39f07ae651985b80511110574fd0a83c4cb8518a/javascript-squid/src/main/java/org/sonar/javascript/parser/sslr/ActionParser2.java
https://github.com/SonarCommunity/sonar-javascript/blob/39f07ae651985b80511110574fd0a83c4cb8518a/javascript-squid/src/main/java/org/sonar/javascript/parser/sslr/SyntaxTreeCreator.java

[Bertk]

Looks promising and will definitely improve the parser error detection.

[guwirth]

Not solvable.