Add an option to include all analysis

[olsh]

At the moment all the imported rules are filtered by this predicate

resharper-clt-plugin/src/main/java/com/soloplan/oss/sonarqube/plugin/resharper/clt/rules/CSharpRulesDefinition.java

Lines 56 to 63 in 0dd7568

	protected @Nullable Collection<Predicate<InspectCodeIssueDefinitionModel>> getIssueDefinitionFilterPredicates() {
	return Arrays.asList(
	ObjectPredicates.isNotNullPredicate(),
	InspectCodePredicates.hasValidIssueSeverity(),
	InspectCodePredicates.hasNonEmptyIssueDescription(),
	InspectCodePredicates.isCSharpIssueDefinition(),
	InspectCodePredicates.isVisualBasicIssueDefinition().negate(),
	InspectCodePredicates.isWebRelatedCategory().negate());

It'd be nice to have an option to disable this filter (except hasValidIssueSeverity and hasNonEmptyIssueDescription) or add two options, something like Rule ID regex and Category ID regex which will control this

resharper-clt-plugin/src/main/java/com/soloplan/oss/sonarqube/plugin/resharper/clt/predicates/InspectCodePredicates.java

Lines 111 to 113 in 0dd7568

	inspectCodeIssueDefinitionModel.getCategory() != null
	&& ("JsStrictModeErrors".equalsIgnoreCase(inspectCodeIssueDefinitionModel.getCategoryId())
	|| "JsStrictModeErrors".equalsIgnoreCase(inspectCodeIssueDefinitionModel.getCategory()));

and this

resharper-clt-plugin/src/main/java/com/soloplan/oss/sonarqube/plugin/resharper/clt/predicates/InspectCodePredicates.java

Line 38 in 0dd7568

Pattern.compile("^\\s*(?!AngularHtml\\.|Asp\\.|Cpp|Css|Es\\dFeature|Html\\.|VB|Web\\.|WebConfig\\.)\\S{3,}", Pattern.CASE_INSENSITIVE);

filter.

This may sound pretty insane, but the R# tools have more analytics than the SQ analyzers, plus R# is more robust at .csthml and .asp(x) parsing.

[BrightLight]

Just to add some background: I understand you'd like to analyze .cshtml and .asp(x) files, which InspectCode can certainly do. However, this plugin currently registers with SonarQube only for .cs files (at least that's my understanding).
Ideally, this plugin basically needs to have a list of available rules per language. But InspectCode only outputs one big XML file (inspectcode_issue_definitions.xml) with all its "issue types", but I don't see an obvious way to figure out which issue type is valid for which language(s). Sure, some are obvious, like Asp.ResolveWarning very likely belongs to .asp(x), CommonJsExternalModule is probably a JavaScript inspection, VBWarnings::BC400005 is obviously a Visual Basic inspection.
But others are not so clear. For instance, RedundantEmptyCaseElse can probably happen in both C# and VB (and maybe even other languages?). Which means when we generate the plugin it is hard to assign the right rules for each language.
Ideally you see in SonarQube for any given language only rules that actually make sense for that language. We just don't know how to get there yet.

[olsh]

Hi @BrightLight ,

However, this plugin currently registers with SonarQube only for .cs files (at least that's my understanding).

I didn't check the registration and import source code, but the plugin imports issues for cshtml, ts, js, css, aspx and other files. I did the changes I mentioned above, and it just works.