Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update computation method for staker rewards #145

Closed
jtse0 opened this issue Nov 2, 2021 · 2 comments · Fixed by #158
Closed

Update computation method for staker rewards #145

jtse0 opened this issue Nov 2, 2021 · 2 comments · Fixed by #158
Assignees
Labels
contracts Smart contracts discussion Needs discussion enhancement New feature or request

Comments

@jtse0
Copy link
Collaborator

jtse0 commented Nov 2, 2021

As mentioned in issue #123 - calculation for staker rewards should take into account the holdings of the user. Formula will be updated to: (staked SLM / total Staked SLM) * reward pool * reward percentage

Each user holding and total holdings will be recorded in the Staker contracts.

@jtse0 jtse0 added enhancement New feature or request contracts Smart contracts labels Nov 2, 2021
@jtse0 jtse0 self-assigned this Nov 2, 2021
@solomondefi-dev solomondefi-dev added the discussion Needs discussion label Nov 3, 2021
@solomondefi-dev
Copy link
Collaborator

This will need some slight clarification, it may be necessary to add a constant modifier or other formula adjustment in order to avoid depleting the reward pool too quickly.

@jtse0
Copy link
Collaborator Author

jtse0 commented Nov 4, 2021

Sorry I actually also updated the formula to include a reward percentage for each payment. We will input a certain reward percentage each payment which will be multiplied by the reward pool each time and then each staker will get their stake of the payment. This reward percentage will just be an extra parameter entered when a new reward payment is announced.

jtse0 added a commit that referenced this issue Nov 9, 2021
@jtse0 jtse0 linked a pull request Nov 12, 2021 that will close this issue
jtse0 added a commit that referenced this issue Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contracts Smart contracts discussion Needs discussion enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants