🚧 [api]: throw error rather than silence fail #93

SolomonDefi · Nov 5, 2021 · 309714b · 309714b
1 parent bc2cabc
commit 309714b
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/libs/blockchain-watcher/feature-app/src/lib/service/ethService.ts b/libs/blockchain-watcher/feature-app/src/lib/service/ethService.ts
@@ -17,7 +17,7 @@ export class EthService {
 
   async onChargebackCreated(chargebackAddress: string) {
     if (!this.provider) {
-      return
+      throw 'Provider is not defined.'
     }
 
     let slmChargeback = await SlmChargeback__factory.connect(
@@ -31,7 +31,7 @@ export class EthService {
 
   async onPreorderCreated(preorderAddress: string) {
     if (!this.provider) {
-      return
+      throw 'Provider is not defined.'
     }
 
     let slmPreorder = await SlmPreorder__factory.connect(preorderAddress, this.provider)
@@ -42,7 +42,7 @@ export class EthService {
 
   async onEscrowCreated(escrowAddress: string) {
     if (!this.provider) {
-      return
+      throw 'Provider is not defined.'
     }
 
     let slmEscrow = await SlmEscrow__factory.connect(escrowAddress, this.provider)
@@ -53,7 +53,7 @@ export class EthService {
 
   async getChargebackCreatedLogs() {
     if (!this.contract) {
-      return
+      throw 'Contract is not defined.'
     }
 
     let eventFilter = this.contract.filters.ChargebackCreated()
@@ -66,7 +66,7 @@ export class EthService {
 
   async getPreorderCreatedLogs() {
     if (!this.contract) {
-      return
+      throw 'Contract is not defined.'
     }
 
     let eventFilter = this.contract.filters.PreorderCreated()
@@ -79,7 +79,7 @@ export class EthService {
 
   async getEscrowCreatedLogs() {
     if (!this.contract) {
-      return
+      throw 'Contract is not defined.'
     }
 
     let eventFilter = this.contract.filters.EscrowCreated()