Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A* Algorithm and other small updates and fixes. #9

Closed

Conversation

OpenSauce
Copy link
Contributor

Hello!

Closes #2

In this I've added an A* method with the relevant heuristics. I've also included the update of the original function to use a map for faster lookup. If there's anything you want changing or adding let me know.

@OpenSauce
Copy link
Contributor Author

Closing as repo is not maintained

@OpenSauce OpenSauce closed this Nov 29, 2023
@OpenSauce OpenSauce deleted the a-star-performance-updates branch November 29, 2023 16:00
@SolarLune
Copy link
Owner

SolarLune commented Dec 6, 2023

Closing as repo is not maintained

I just merged a PR a few weeks ago, so the repo isn't unmaintained; I just forgot to review this PR, sorry.


As for the PR itself, I believe it could be useful to have A* pathfinding, but I think it would be better to simply rewrite the existing pathfinding function to accept a customizeable path searching algorithm, rather than having a separate function for A* pathfinding (or even just make A* the default).

There were also a few spelling issues ("Diaganal" instead of "Diagonal", "Manhatten" instead of "Manhattan").

It also would be good not to use individual letters for values unless it's very obvious what they do (i.e. Node.g and Node.h should probably be something else more descriptive).

In short, A* pathfinding could be very good, but it would need to be approached cleanly (ideally, in a way that makes the existing pathfinding system even cleaner).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Todo List
2 participants