Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system-rules is not needed as a dependency #101

Closed
codefiddler opened this issue Jun 15, 2023 · 0 comments · Fixed by #100 or #133
Closed

system-rules is not needed as a dependency #101

codefiddler opened this issue Jun 15, 2023 · 0 comments · Fixed by #100 or #133
Labels
dependencies Pull requests that update a dependency file

Comments

@codefiddler
Copy link

The following maven dependency is not needed:

		<groupId>com.github.stefanbirkner</groupId>
		<artifactId>system-rules</artifactId>
		<version>1.19.0</version>
		<scope>test</scope>

The only reason for including it is the transient dependency to junit 4.

I have made a pull request: #100
@Nephery Nephery linked a pull request Jun 15, 2023 that will close this issue
Removed system-rules maven dependency. #100
Merged
@Nephery Nephery added the dependencies Pull requests that update a dependency file label Oct 16, 2023
mayur-solace added a commit to SolaceDev/solace-spring-boot that referenced this issue Jul 17, 2024
@mayur-solace
Remove unwanted test dependency as requested in SolaceProducts#101
1f54f96 
Use slf4j instead of apache logging
@mayur-solace mayur-solace mentioned this issue Jul 17, 2024
Merged
mayur-solace added a commit that referenced this issue Jul 18, 2024
@mayur-solace @Nephery
Add OAuth2 support for authentication with Solace PubSub+ Broker. (#133)
39febc5 
* Add OAuth2 support for authentication with Solace PubSub+ Broker
* Disable overwrite settings in setup-java (#40)
* Updated dev docs.
* Fix action permissions (#41)
* fix manual test support install version
* Remove unwanted test dependency as requested in #101
Use slf4j instead of apache logging

---------

Co-authored-by: Jeffrey D <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
2 participants
@codefiddler @Nephery