Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AI-166: fix inconsistency with payload/data responses #49

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

efunneko
Copy link
Collaborator

Responses from the openai and langchain components were inconsistent with what data was placed in a message payload (for new streaming messages) and the data in the return from the invoke function. This led to problems in downstream components, some that used the payload data and some that used the previous component data.

This change may be non-backwards compatible, depending on how it was used.

@efunneko efunneko requested a review from gregmeldrum October 11, 2024 19:32
@efunneko efunneko self-assigned this Oct 11, 2024
Copy link

gitstream-cm bot commented Oct 11, 2024

Please mark whether you used Copilot to assist coding in this PR

  • Copilot Assisted

Copy link

@efunneko efunneko merged commit ab2083f into main Oct 15, 2024
5 checks passed
@efunneko efunneko deleted the ed/fix-openai-streaming branch October 15, 2024 13:59
@efunneko efunneko restored the ed/fix-openai-streaming branch November 30, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants