Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ap/add websearch component #48

Merged
merged 10 commits into from
Oct 22, 2024
Merged

Ap/add websearch component #48

merged 10 commits into from
Oct 22, 2024

Conversation

alimosaed
Copy link

Changes Made

  • Implemented web search and scraping agents for Google, DuckDuckGo, and Bing.
  • Created stand-alone workflows for each of the new agents.
  • Developed a comprehensive flow that routes requests to either web search or LLM based on the request body.
  • Introduced a filter to trim the LLM output by removing unnecessary data from the JSON object.
  • Enabled the response_format tag in openai_chat_model_base.py to force OpenAI to generate a trimmed JSON object.
  • Added 'unicode_escape' encoding to the broker_base.py to generate results without '\n'.

Testing

  • Build the Solace AI Connector. Navigate to the root of the project and run
pip install .
  • Run each YAML files by
solace-ai-connector <name>.yaml
  • The required inputs per use case have been documented on top of each YAML file.

Documentation

  • The required packages have been documented on Readme.md files.
  • The required inputs per use case have been documented on top of each YAML file.

@alimosaed alimosaed self-assigned this Oct 3, 2024
Copy link

gitstream-cm bot commented Oct 3, 2024

Please mark whether you used Copilot to assist coding in this PR

  • Copilot Assisted

Copy link

@cyrus2281 cyrus2281 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments

docs/getting_started.md Outdated Show resolved Hide resolved
examples/llm/openai_chat.yaml Outdated Show resolved Hide resolved
examples/websearch/bing_web_search.yaml Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
Copy link

@cyrus2281 cyrus2281 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Please just run the doc generator command to update the documents.

Just to clarify, the parser does not support tag extraction and then parsing. it only takes in the whole passed in input

@cyrus2281
Copy link

Run make gen-docs

@alimosaed
Copy link
Author

  • Built documents
  • Updated the error messages

Copy link

SonarQube Quality Gate

Quality Gate failed

0.0% 0.0% Security Hotspots Reviewed on New Code (is less than 100%)

See analysis details on SonarQube

@alimosaed alimosaed merged commit c47e598 into main Oct 22, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants