deprecate the use of FilePath.update_all, simplify the invocation of …

…get_path

pycvsanaly2/extensions/FilePaths.py

@@ -42,10 +42,11 @@ def __init__ (self):
     def __init__ (self, db):
         self.__dict__ = self.__shared_state
         self.__dict__['db'] = db
-        
+
     def update_for_revision (self, cursor, commit_id, repo_id):
         db = self.__dict__['db']
 
+        #TODO check all places using this method to remove this if statement
         if commit_id == self.__dict__['rev']:
             return
 
@@ -144,10 +145,15 @@ def __build_path (self, file_id, adj):
 
     def get_path (self, file_id, commit_id, repo_id):
         profiler_start ("Getting path for file %d at commit %d", (file_id, commit_id))
+        #Test here if avoid unnecessary database connection
+        if commit_id != self.__dict__['rev']:
+            cnn = self.__dict__['db'].connect()
+            cursor = cnn.cursor()
+            self.update_for_revision(cursor, commit_id, repo_id)
+            cursor.close()
+            self.__dict__['rev'] = commit_id
 
         adj = self.__dict__['adj']
-        assert adj is not None, "Matrix no updated"
-
         path = self.__build_path (file_id, adj)
 
         profiler_stop ("Getting path for file %d at commit %d", (file_id, commit_id), True)
@@ -166,6 +172,7 @@ def get_commit_id (self):
         return self.__dict__['rev']
 
     def update_all(self, repo_id):
+        print("Deprecation warning: FilePath.update_all has discovered defects!")
         db = self.__dict__['db']
         cnn = db.connect ()
 

pycvsanaly2/extensions/HunkBlame.py

@@ -117,7 +117,7 @@ class HunkBlame(Blame):
     '''
     classdocs
     '''
-    deps = ['Hunks']
+#    deps = ['Hunks']
 
     MAX_BLAMES = 1
 
@@ -217,7 +217,6 @@ def run (self, repo, uri, db):
         hunk = read_cursor.fetchone()
         n_blames = 0
         fp = FilePaths(db)
-        fp.update_all(repoid)
 
         while hunk is not None:
             hunk_id, file_id, commit_id, start_line, end_line, rev = hunk