adding target blank noopener noreferrer to navLinks #196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd suggest adding
target="_blank" rel="noopener noreferrer"
to the nav links, since these are generally used for external links, it might be good if they open in a new window?<?js if(betterDocs.navLinks && betterDocs.navLinks.length) { ?> <?js betterDocs.navLinks.forEach(function(link) { ?> <a class="link user-link <?js= link.className ? link.className : '' ?>" href="<?js= link.href ?>" + target="_blank" rel="noopener noreferrer" > <?js= link.label ?> </a> <?js }) ?> <?js } ?>