Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect file path in Windows platform #1668

Merged
merged 4 commits into from
Jul 1, 2024
Merged

fix: incorrect file path in Windows platform #1668

merged 4 commits into from
Jul 1, 2024

Conversation

destyk
Copy link
Contributor

@destyk destyk commented Jun 2, 2024

When importing a custom component on the Windows platform, there was a problem with determining the path. This PR also fixes the problem with the Cyrillic alphabet in the file path.

Before:
\D:%D0%9D%D0%B8%D0%BA%D0%B8%D1%82%D0%B0\project\dist\components\photo

After:
D:\Никита\project\dist\components\photo

@dziraf
Copy link
Contributor

dziraf commented Jun 26, 2024

@destyk I'm OK with merging your PR but could you fix types since CI seems to be failing now?

@dziraf dziraf merged commit 1c25e60 into SoftwareBrothers:master Jul 1, 2024
4 checks passed
Copy link

github-actions bot commented Jul 1, 2024

🎉 This PR is included in version 7.8.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants