fix <TextEdit /> bugs #1380
fix <TextEdit /> bugs #1380
Conversation
fix: array item re-render issue
|
|
||
| return ( | ||
| <Draggable | ||
| draggableId={uniqueDraggableId} | ||
| draggableId={property.path} |
There was a problem hiding this comment.
Does this fix the issue? property.path is still not unique as it changes when you drag an element between indices.
There was a problem hiding this comment.
That's a fair point will have to dive into that.
There was a problem hiding this comment.
There doesn't seem to be a convenient value to use as a unique key.
There was a problem hiding this comment.
One solution I thought of would be to create a "virtual" property draggableId for all existing array elements when the HOC component first loads, then assign it also when you add new elements. We could use some kind of library like nanoid to create a unique identifier. There could be an issue where AdminJS also sends this property in request payload and an adapter tries to save it. AFAIK some ORMs skip attributes that are not defined in models when generating db queries but other ones could throw errors. A solution to this could be that we treat all properties prefixed with double underscore (__typename, __draggableId, etc) as virtual/readonly and remove them when form is submitted.
There was a problem hiding this comment.
Would you want that solution as part of this PR?
There was a problem hiding this comment.
Ideally, yes. If you have doubts though and property.path change works exactly the same as uniqueDraggableId (as it was before) then it's fine to do it another time.
There was a problem hiding this comment.
I would prefer handling it in a separate PR, the current implementation has some quirks like focus going to the wrong field when dragging elements. But that is an existing issue.
|
You're right will add that back into the PR |
|
Currently AdminJS has a lot of different components for different types of data, they have repeating functionality. This PR doesn't address all of them. If the changes so far seem sound, I can continue to try to implement the same for the rest of the property-type components. |
This is a re-attempt at #1356