Fix Linux build & some warnings #6438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f deps on Linux. This prevents downloading the same source packages twice, and avoid downloading again after deleting the build dir.
…ble binds to a temporary constructed from type"
|
Snap. I was busy making the same fixes 🤓 The ../deps outside the code tree puzzled me. |
|
I would love to know how Orca worked the (un)sorted assert which was introduced 3 months ago. |
henrivdr
pushed a commit
to henrivdr/OrcaSlicer
that referenced
this pull request
Aug 18, 2024
* Fix linux deps debug build * Use the same DL_CACHE for release build when building debug version of deps on Linux. This prevents downloading the same source packages twice, and avoid downloading again after deleting the build dir. * Fix debug build * Fix warnings "loop variable creates a copy from type" and "loop variable binds to a temporary constructed from type"
Ocraftyone
added a commit
to Ocraftyone/OrcaSlicer-Ocraftyone
that referenced
this pull request
Sep 13, 2024
The root cause for not being able to find the debug version of Qhull was solved in SoftFever#6438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Linux Debug build.
Fixes some "loop variable creates a copy from type" and "loop variable binds to a temporary constructed from type" warnings so for loops should be slightly faster.