Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing high GPU usage when color scheme is set to "Filament" or "Speed" #6223

Merged

Conversation

Azio-Pantheon
Copy link
Contributor

First time contributing, I hope I'm doing this correctly.

Description

Removed imgui.set_requires_extra_frame(), this line causes Slic3r::GUI::GLCanvas3D::render() to be called repeatedly when 'Filament' or 'Speed' is selected in the preview panel (even when OrcaSlicer is minimized)

This should fix #3594

I see that this line was added in #3363. I don't fully understand the intention behind it, but removing this line does not seem to affect the legend window fix

Screenshots/Recordings/Graphs

Now in "Filament" or "Speed" preview, GPU usage is 0% when OrcaSlicer is minimized or idle.

Before:
Screenshot 2024-07-22 183641

After:
Screenshot 2024-07-22 183917

…I::GLCanvas3D::render() to be called repeatedly when 'Filament' or 'Speed' is selected for preview panel
@vovodroid
Copy link
Contributor

vovodroid commented Jul 23, 2024

Great finding! It also reduces CPU usage, not only GPU. Merging it into my fork, thanks!

vovodroid added a commit to vovodroid/OrcaSlicer that referenced this pull request Jul 23, 2024
@discip
Copy link
Contributor

discip commented Jul 23, 2024

@azio25134

Thank you SIR! 😃👍

Am I right to assume that the flow-scheme is also affected?

@vovodroid
Copy link
Contributor

Am I right to assume that the flow-scheme is also affected?

I don't see such problem in Orca 2.1.1, so your fix affects only Filament and Speed.

@Azio-Pantheon
Copy link
Contributor Author

@azio25134

Thank you SIR! 😃👍

Am I right to assume that the flow-scheme is also affected?

It only affects Filament and Speed as far as I know.

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!
Thank you

@SoftFever SoftFever merged commit b40e6c0 into SoftFever:main Jul 25, 2024
16 checks passed
@Azio-Pantheon Azio-Pantheon deleted the bugfix/high_gpu_usage_in_preview branch July 25, 2024 18:19
@birdoplo
Copy link

birdoplo commented Aug 1, 2024

In which file is the string imgui.set_requires_extra_frame() ?

@vovodroid
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High GPU usage when color scheme is set to "Filament" or "Speed"
5 participants