Fixing high GPU usage when color scheme is set to "Filament" or "Speed" #6223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributing, I hope I'm doing this correctly.
Description
Removed
imgui.set_requires_extra_frame()
, this line causes Slic3r::GUI::GLCanvas3D::render() to be called repeatedly when 'Filament' or 'Speed' is selected in the preview panel (even when OrcaSlicer is minimized)This should fix #3594
I see that this line was added in #3363. I don't fully understand the intention behind it, but removing this line does not seem to affect the legend window fix
Screenshots/Recordings/Graphs
Now in "Filament" or "Speed" preview, GPU usage is 0% when OrcaSlicer is minimized or idle.
Before:
After: