Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameters not updating on non active tabs #5400

Merged
merged 1 commit into from
May 19, 2024

Conversation

yw4z
Copy link
Contributor

@yw4z yw4z commented May 19, 2024

Bug appeared after #5386

Updates all tabs instead only active tab

Maybe requires a bit more testing

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. It looks to be working fine. I will merge it first as it has fixed the issue in the current main branch.

@SoftFever SoftFever merged commit 3f83d68 into SoftFever:main May 19, 2024
12 checks passed
@kisslorand
Copy link
Contributor

@yw4z
Could you please extend this fix to preload all tabs when OrcaSlicer is loaded?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants