Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented minimum skirt extrusion length and draft shield parameter #5356

Merged

Conversation

igiannakas
Copy link
Contributor

@igiannakas igiannakas commented May 13, 2024

Description

For certain use cases it may be useful to implement a parameter that controls the minimum amount of filament in mm that is purged out at the skirt. For example, when no purge line is used a minimum skirt length can be employed to ensure the nozzle is primed.

In addition, certain use cases benefit from having the option to easily enable a draft shield - i.e. a skirt as tall as the object itself. This is useful when printing warp prone material in an open frame printer.

Finally split the adhesion options into two groups - one for skirt and one for brim, to clean up the UI

This is a localised change as the code was already present in the code base, just deactivated as the option was not exported in the UI.

Screenshots/Recordings/Graphs

Before:
image

After:
Skirt extrusion length:
image

Draft shield:
image

Tests

Validated with 0 minimum skirt length -> number of loops is respected
Validated with multi material selection -> first tool is used to print the skirt as expected
Validated draft shield functioning

Limitations

Due to the way skirts are constructed in the slicer, having a greater than 1 layer skirt height or the draft shield active will result in the minimum extrusion amount being extruded for each layer where the skirt is printed. This may or may not be desirable. If not desirable, the user should set the skirt height to 1 layer.

Fixes

Fixes #5343
Fixes #1068
Fixes #3718
Fixes #1630
Fixes #4408

@netweaver1970
Copy link

works fine for me, thanks!
I settled at 15mm, with Eryone ABS, 260 degr, on a Dragon HF. Maybe could go to 10mm but just errored a bit on the safe side.

@igiannakas igiannakas changed the title Implemented minimum skirt extrusion length parameter Implemented minimum skirt extrusion length and draft shield parameter May 14, 2024
@ahmetcemturan
Copy link

Tahnk you. Unfortunately I can not test it but does it allow you to set the distance of the draftshield from the object? I might need a wide skirt with a closely draftshield closely placed to the object (e.g.for PA or PC).

@igiannakas
Copy link
Contributor Author

Hi there

this PR implements a draft shield the exact same way as prusa slicer. Have a look there to confirm ;)

@ahmetcemturan
Copy link

ahmetcemturan commented May 17, 2024 via email

@SoftFever
Copy link
Owner

@igiannakas
Looks like the draft shield is not enabled.

@igiannakas
Copy link
Contributor Author

hey @SoftFever not sure what you mean? what am I missing .......?

below is from the latest pr build

image

@SoftFever
Copy link
Owner

SoftFever commented May 19, 2024

hey @SoftFever not sure what you mean? what am I missing .......?

below is from the latest pr build

image

Hmm, I guess you have dev mode enabled in your application settings that's why you can see the draft shield option.
We need to change draft_shield option from comDevelop to comAdvance to it available for normal mode

@igiannakas
Copy link
Contributor Author

Duh I’m stupid haha! I’ll fix it

@igiannakas
Copy link
Contributor Author

Done, updated to comAdvanced ;)

@SoftFever
Copy link
Owner

hehehe, thanks.
It looks good 👍

@SoftFever SoftFever merged commit dd36d5b into SoftFever:main May 20, 2024
12 checks passed
@igiannakas igiannakas deleted the Minimum-skirt-filament-purge-length branch May 20, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants