Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated arc fitting pop up to clarify that this option should not be enabled for Klipper machines #5352

Conversation

igiannakas
Copy link
Contributor

@igiannakas igiannakas commented May 13, 2024

Description

Klipper does not natively support arc commands at the motion controller level. Hence enabling arc fitting on Klipper is detrimental to print quality as line segments are converted to arcs in the slicer and back to line segments in Klipper.

The revised pop up wording clarifies that this option is not recommended for Klipper printers.

Fixes #5297
Fixes #4216

@discip
Copy link
Contributor

discip commented May 13, 2024

@igiannakas
To make this even easier:
Why not just disable and hide this feature once you set G-Code flavor to Klipper? 😊

@igiannakas
Copy link
Contributor Author

@igiannakas To make this even easier: Why not just disable and hide this feature once you set G-Code flavor to Klipper? 😊

Because for some reason someone may want to use it I suppose…

@bistory
Copy link
Contributor

bistory commented May 13, 2024

From Orca 1.6.1 to 1.6.4 ( https://github.com/SoftFever/OrcaSlicer/releases/tag/v1.6.4 ), there was a note in the release not page encouraging people to enable Arc fitting.
But I totally understand your point, I will probably stop using it in my profiles ;-)

@igiannakas
Copy link
Contributor Author

igiannakas commented May 13, 2024

From Orca 1.6.1 to 1.6.4 ( https://github.com/SoftFever/OrcaSlicer/releases/tag/v1.6.4 ), there was a note in the release not page encouraging people to enable Arc fitting. But I totally understand your point, I will probably stop using it in my profiles ;-)

No that note is recommending enabling support in klipper because some non extrusion moves use arc commands. For example spiral z hop uses arcs. As this is not a printing command it doesn’t matter that arcs are used. It’s not recommending that arc fitting is enabled in the print settings in the slicer ;)

@bistory
Copy link
Contributor

bistory commented May 13, 2024

From Orca 1.6.1 to 1.6.4 ( https://github.com/SoftFever/OrcaSlicer/releases/tag/v1.6.4 ), there was a note in the release not page encouraging people to enable Arc fitting. But I totally understand your point, I will probably stop using it in my profiles ;-)

No that note is enabling support in klipper because some non extrusion moves use arc commands. For example spiral z hop uses arcs. As this is not a printing command it doesn’t matter that arcs are used.

Understood ! Thanks !

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally agree here.
Enabling ARC fitting for Klipper is not recommended.

@SoftFever SoftFever merged commit c482a62 into SoftFever:main May 18, 2024
12 checks passed
@igiannakas igiannakas deleted the Arc-fitting-updated-pop-up-for-Klipper-machines branch May 18, 2024 23:13
@igiannakas igiannakas restored the Arc-fitting-updated-pop-up-for-Klipper-machines branch May 18, 2024 23:13
@igiannakas igiannakas deleted the Arc-fitting-updated-pop-up-for-Klipper-machines branch May 18, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants